Repository navigation
refactor: [M3-8641] - Move Box component to ui package (Part 1) - #11163
Merged
Merged
Conversation
coliu-akamai
marked this pull request as ready for review
October 25, 2024 14:36
coliu-akamai
requested review from
carrillo-erik and
cpathipa
and removed request for
a team
October 25, 2024 14:36
coliu-akamai
marked this pull request as draft
October 25, 2024 14:37
coliu-akamai
marked this pull request as ready for review
October 25, 2024 15:24
|
Coverage Report: ✅ |
bnussman-akamai
approved these changes
Oct 25, 2024
coliu-akamai
commented
Oct 28, 2024
| @@ -0,0 +1 @@ | |||
| export * from './Box'; | |||
Contributor
Author
There was a problem hiding this comment.
See this comment for rationale behind moving Box into its own package within the ui package
coliu-akamai
requested review from
dwiley-akamai,
hkhalil-akamai and
jaalah-akamai
October 29, 2024 13:13
cpathipa
added
Approved
hkhalil-akamai
approved these changes
Oct 29, 2024
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
Contributor
There was a problem hiding this comment.
Moar merge conflicts😭😭
2 of 12 tasks
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 26m 52s |
| Commit |
|
| Committer | Connie Liu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Part 1 of moving
Boxto theuipackage.Boxtouches so many files, so I've tried splitting this up to avoid a mega 220+ file PR. I was having trouble trying to split this up in a way that made sense (esp bc Box is used everywhere, including other components) but I tried to focus on features only for this PRChanges 🔄
How to test 🧪
Make sure there's no regressions in overall styling/layout in these specific areas:
As an Author I have considered 🤔
Check all that apply