Repository navigation
upcoming: [M3-6700] - Replace one-off hardcoded black and white color values with colorTokens - #11165
Merged
Conversation
pmakode-akamai
marked this pull request as ready for review
October 25, 2024 16:05
pmakode-akamai
requested review from
dwiley-akamai and
hkhalil-akamai
and removed request for
a team
October 25, 2024 16:05
pmakode-akamai
changed the title
…es with colorTokens
|
Coverage Report: ✅ |
dwiley-akamai
approved these changes
Oct 25, 2024
pmakode-akamai
changed the title
2 of 12 tasks
jaalah-akamai
approved these changes
Oct 28, 2024
jaalah-akamai
left a comment
jaalah-akamai
left a comment
Contributor
There was a problem hiding this comment.
Keep in mind the structure change we talked about - up to you how you want to handle that in this PR or in a future one.
jaalah-akamai
added
Approved
hkhalil-akamai
approved these changes
Oct 28, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 25m 36s |
| Commit |
|
| Committer | Purvesh Makode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
445
|
| View all changes introduced in this branch ↗︎ | |
3 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
colorTokens- Part 2colorTokensare global tokens, and they are theme-agnostic.Note
theme.colorTokens.Neutrals.Blackis pitch black ("#232326") in design tokensChanges 🔄
#000orblackwiththeme.colorTokens.Neutrals.Black("#232326")#ffforwhitewiththeme.colorTokens.Neutrals.WhiteTarget release date 🗓️
N/A
Preview 📷
#000orblackis now pitch black ("#232326") as per neutral black design color tokenHow to test 🧪
Verification steps
As an Author I have considered 🤔
Check all that apply