Skip to content

fix: [M3-8743] - fix aria label of action menu in IP address table row. #11167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnussman-akamai merged 6 commits into from
Nov 1, 2024
Merged

fix: [M3-8743] - fix aria label of action menu in IP address table row. #11167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b2b7f88
fix: [M3-8743] - fix aria label of action menu in IP address table row.
hasyed-akamai Oct 28, 2024
17ac5b0
Added changeset: fix aria label of action menu button in IP address t…
hasyed-akamai Oct 28, 2024
c17d624
Update changeset Description.
hasyed-akamai Oct 28, 2024
7b0a2c7
remove the optional chaining '?'
hasyed-akamai Oct 28, 2024
d1a243d
Make ipAddress prop required.
hasyed-akamai Oct 29, 2024
2d9d87b
remove ipAddress check in condition
hasyed-akamai Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-11167-fixed-1730095848948.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Fixed
---

aria label of action menu button in IP address table row ([#11167](https://github.com/linode/manager/pull/11167))
15 changes: 10 additions & 5 deletions ...anager/src/features/Linodes/LinodesDetail/LinodeNetworking/LinodeNetworkingActionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import type { Theme } from '@mui/material/styles';
import type { Action } from 'src/components/ActionMenu/ActionMenu';

interface Props {
ipAddress?: IPAddress | IPRange;
ipAddress: IPAddress | IPRange;
ipType: IPTypes;
isOnlyPublicIP: boolean;
isVPCOnlyLinode: boolean;
Expand Down Expand Up @@ -59,6 +59,14 @@ export const LinodeNetworkingActionMenu = (props: Props) => {
? 'Linodes must have at least one public IP'
: undefined;

const getAriaLabel = (): string => {
if ('address' in ipAddress) {
return `Action menu for IP Address ${ipAddress.address}`;
} else {
return `Action menu for IP Address ${ipAddress.range}`;
}
};

const actions = [
onRemove && ipAddress && !is116Range && deletableIPTypes.includes(ipType)
? {
Expand Down Expand Up @@ -110,10 +118,7 @@ export const LinodeNetworkingActionMenu = (props: Props) => {
);
})}
{matchesMdDown && (
<ActionMenu
actionsList={actions}
ariaLabel={`Action menu for IP Address ${props.ipAddress}`}
/>
<ActionMenu actionsList={actions} ariaLabel={getAriaLabel()} />
)}
</>
) : (
Expand Down