feat: [UIE-8082] - DBaaS GA Database Resize refactoring by mpolotsk-akamai · Pull Request #11180 · linode/manager

mpolotsk-akamai · 2024-10-29T12:26:25Z

Description 📝

DBaaS GA: Database Resize refactoring

Changes 🔄

List any change relevant to the reviewer.

Refactoring Database Resize
- The only real changes in this PR are DatabaseResize.tsx. Everything else is from the previous PR.

Target release date 🗓️

11/12/24

How to test 🧪

Prerequisites

(How to setup test environment)

Verification steps

(How to verify changes)

As an Author I have considered 🤔

Check all that apply

mjac0bs · 2024-10-29T16:19:10Z

Hey @mpolotsk-akamai, this is a large PR with a diff of 1600+ lines, and it's introducing a few new components without test coverage.

Could we break this down into 2 PRs: Database Create updates in the first PR, and Database Resize refactor in the second? This would lead to faster review and more isolated changes. I'm also not sure if lack of unit tests is intentional - are these changes going to be covered in Cypress flows in an upcoming ticket?

mpolotsk-akamai · 2024-10-29T16:38:58Z

Hey @mpolotsk-akamai, this is a large PR with a diff of 1600+ lines, and it's introducing a few new components without test coverage.

Could we break this down into 2 PRs: Database Create updates in the first PR, and Database Resize refactor in the second? This would lead to faster review and more isolated changes. I'm also not sure if lack of unit tests is intentional - are these changes going to be covered in Cypress flows in an upcoming ticket?

Hey @mjac0bs, sure, I will break this down and will add unit tests. Thanks

github-actions · 2024-10-31T17:09:54Z

Coverage Report: ✅
Base Coverage: 87.33%
Current Coverage: 87.33%

mpolotsk-akamai · 2024-10-31T17:56:01Z

Hey @mpolotsk-akamai, this is a large PR with a diff of 1600+ lines, and it's introducing a few new components without test coverage.
Could we break this down into 2 PRs: Database Create updates in the first PR, and Database Resize refactor in the second? This would lead to faster review and more isolated changes. I'm also not sure if lack of unit tests is intentional - are these changes going to be covered in Cypress flows in an upcoming ticket?

Hey @mjac0bs, sure, I will break this down and will add unit tests. Thanks

Hey @mjac0bs, I created another PR #11193 for Database Create Summary Section, refactoring, and this existing PR #11180 is for Database Resize refactoring.
However these PRs changes are connected, PR #11193 depends on PR #11180, because they have shared components.

mjac0bs

Thanks @mpolotsk-akamai - functionality looked good overall here.

Minor things:

We're missing a changeset for the actual changes in this PR.
There's typecheck warnings in this PR that I did not see in the previous Create PR. You'll want to take a look at these imports.
I am still seeing the extra spacing before the number of nodes in the summary section, so I don't think that change got carried over when you were resolving conflicts.

mjac0bs · 2024-11-04T20:21:40Z

Oh, there's some unit test flake still to fix. It passed the test-manager job in CI, but failed the current branch code coverage job. Locally, I can see it flake as well.

…or node selection and summary section.

cpathipa

@mpolotsk-akamai Looks like some failed E2E tests are related to the database refactoring. Could you please look into that? Other than that, the changes look good to me, and this is good to go once those tests pass.

mpolotsk-akamai · 2024-11-05T15:23:47Z

@cpathipa , I'm working on it, thanks!

linode-gh-bot · 2024-11-05T17:57:46Z

Cloud Manager UI test results

🔺 1 failing test on test run #17 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`1 Failing`	`444 Passing`	`2 Skipped`	`96m 56s`

Details

Failing Tests
	Spec	Test
❌	`clone-linode.spec.ts`	clone linode » can clone a Linode from Linode details page

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts"

cpathipa

Thank you for addressing the feedback @mpolotsk-akamai

cypress · 2024-11-05T19:15:06Z

Cloud Manager E2E Run #6785

Run Properties: Failed #6785 • 8e007a791c: feat: [UIE-8082] - DBaaS GA Database Resize refactoring (#11180)

Project	`Cloud Manager E2E`
Branch Review	`develop`
Run status	`Failed #6785`
Run duration	`30m 50s`
Commit	`8e007a791c: feat: [UIE-8082] - DBaaS GA Database Resize refactoring (#11180)`
Committer	`mpolotsk-akamai`
View all properties for this run ↗︎

Test results
Failures	`4`
Flaky	`2`
Pending	`2`
Skipped	`0`
Passing	`441`
View all changes introduced in this branch ↗︎

Tests for review

cypress/e2e/core/databases/resize-database.spec.ts • 4 failed tests

View Output Video

Test		Artifacts
Resizing existing clusters > Resizes a g6-standard-6 MySQL v8.x 3-node cluster > Can resize active database clusters		`Screenshots` `Video`
Resizing existing clusters > Resizes a g6-standard-6 MySQL v8.x 3-node cluster > Can resize active database clusters from g6-standard-6 type and switch plan type		`Screenshots` `Video`
Resizing existing clusters > Resizes a g6-dedicated-16 MySQL v5.x 3-node cluster > Can resize active database clusters		`Screenshots` `Video`
Resizing existing clusters > Resizes a g6-dedicated-16 MySQL v5.x 3-node cluster > Can resize active database clusters from g6-dedicated-16 type and switch plan type		`Screenshots` `Video`

linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
clone linode > can clone a Linode from Linode details page		`Screenshots` `Video`

volumes/create-volume.smoke.spec.ts • 1 flaky test

View Output Video

Test		Artifacts
volumes > does not allow creation of a volume with invalid pricing from volumes landing		`Screenshots` `Video`

mpolotsk-akamai requested a review from a team as a code owner October 29, 2024 12:26

mpolotsk-akamai requested review from hana-akamai and mjac0bs and removed request for a team October 29, 2024 12:26

coliu-akamai assigned mpolotsk-akamai Oct 29, 2024

coliu-akamai added the DBaaS Relates to Database as a Service label Oct 29, 2024

cpathipa requested review from cpathipa and removed request for hana-akamai October 29, 2024 16:01

mpolotsk-akamai changed the title ~~feat: [UIE-8082] - DBaaS GA Database Create (Summary Section), refactoring~~ feat: [UIE-8082] - DBaaS GA Database Resize refactoring Oct 31, 2024

mpolotsk-akamai force-pushed the UIE-8082-DBaaS-GA-Create branch from 6c5bd43 to fffc304 Compare October 31, 2024 14:59

mpolotsk-akamai requested a review from a team as a code owner October 31, 2024 14:59

mpolotsk-akamai requested review from cliu-akamai and removed request for a team October 31, 2024 14:59

mpolotsk-akamai force-pushed the UIE-8082-DBaaS-GA-Create branch from fffc304 to 6d52eaa Compare October 31, 2024 16:35

mpolotsk-akamai force-pushed the UIE-8082-DBaaS-GA-Create branch 2 times, most recently from 4d18b73 to 6d52eaa Compare October 31, 2024 17:23

cpathipa removed the request for review from cliu-akamai November 1, 2024 14:15

corya-akamai mentioned this pull request Nov 1, 2024

feat: [UIE-8194] - DBaaS Upgrades and Maintenance 1 #11196

Merged

5 of 12 tasks

mpolotsk-akamai force-pushed the UIE-8082-DBaaS-GA-Create branch 2 times, most recently from 2b4e792 to 2974568 Compare November 4, 2024 18:14

mjac0bs added the Missing Changeset label Nov 4, 2024

cpathipa removed the Missing Changeset label Nov 4, 2024

mjac0bs approved these changes Nov 4, 2024

View reviewed changes

cpathipa reviewed Nov 4, 2024

View reviewed changes

Comment thread packages/manager/src/features/Databases/DatabaseCreate/DatabaseCreate.tsx Outdated

feat: [UIE-8082] - DBaaS GA Database Create Summary section, refactoring

18a54c9

mpolotsk-akamai added 3 commits November 5, 2024 10:37

Added changeset: Added Summary Section for Database Create GA

5607de0

change: [UIE-8082] - DBaaS GA Database Resize refactoring

4d24022

refactoring: [UIE-8082] - DBaaS GA Database Resize review fix

4cb6130

mpolotsk-akamai force-pushed the UIE-8082-DBaaS-GA-Create branch 2 times, most recently from 627b9be to cb0b441 Compare November 5, 2024 10:47

mpolotsk-akamai requested a review from cpathipa November 5, 2024 10:55

Added changeset: Refactored DatabaseResize to use shared components f…

b89e82c

…or node selection and summary section.

mpolotsk-akamai force-pushed the UIE-8082-DBaaS-GA-Create branch from cb0b441 to b89e82c Compare November 5, 2024 12:50

cpathipa reviewed Nov 5, 2024

View reviewed changes

flag for monitor tab

11a1e66

cpathipa approved these changes Nov 5, 2024

View reviewed changes

cpathipa merged commit 8e007a7 into linode:develop Nov 5, 2024

jaalah-akamai mentioned this pull request Nov 7, 2024

Release v1.132.0 - release → staging #11220

Merged

hana-akamai mentioned this pull request Nov 12, 2024

Release v1.132.0 - staging → master #11249

Merged

Navigation Menu

Repository navigation

feat: [UIE-8082] - DBaaS GA Database Resize refactoring - #11180

feat: [UIE-8082] - DBaaS GA Database Resize refactoring#11180
cpathipa merged 6 commits into
linode:developfrom
mpolotsk-akamai:UIE-8082-DBaaS-GA-Create

mpolotsk-akamai commented Oct 29, 2024 •

edited by mjac0bs

Loading

Uh oh!

mjac0bs commented Oct 29, 2024

Uh oh!

mpolotsk-akamai commented Oct 29, 2024

Uh oh!

github-actions Bot commented Oct 31, 2024 •

edited

Loading

Uh oh!

mpolotsk-akamai commented Oct 31, 2024

Uh oh!

mjac0bs left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mjac0bs commented Nov 4, 2024

Uh oh!

Uh oh!

cpathipa left a comment

Uh oh!

mpolotsk-akamai commented Nov 5, 2024

Uh oh!

linode-gh-bot commented Nov 5, 2024

Uh oh!

cpathipa left a comment

Uh oh!

cypress Bot commented Nov 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mpolotsk-akamai commented Oct 29, 2024 • edited by mjac0bs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Changes 🔄

Target release date 🗓️

How to test 🧪

Prerequisites

Verification steps

As an Author I have considered 🤔

Uh oh!

mjac0bs commented Oct 29, 2024

Uh oh!

mpolotsk-akamai commented Oct 29, 2024

Uh oh!

github-actions Bot commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mpolotsk-akamai commented Oct 31, 2024

Uh oh!

mjac0bs left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mjac0bs commented Nov 4, 2024

Uh oh!

Uh oh!

cpathipa left a comment

Choose a reason for hiding this comment

Uh oh!

mpolotsk-akamai commented Nov 5, 2024

Uh oh!

linode-gh-bot commented Nov 5, 2024

Cloud Manager UI test results

🔺 1 failing test on test run #17 ↗︎

Details

Troubleshooting

Uh oh!

cpathipa left a comment

Choose a reason for hiding this comment

Uh oh!

cypress Bot commented Nov 5, 2024

Cloud Manager E2E Run #6785

Tests for review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mpolotsk-akamai commented Oct 29, 2024 •

edited by mjac0bs

Loading

github-actions Bot commented Oct 31, 2024 •

edited

Loading

mjac0bs left a comment •

edited

Loading