Repository navigation
change: [M3-8961] - Change Pendo sanitized url path string to match UXR request - #11361
Merged
mjac0bs merged 2 commits intoDec 4, 2024
Merged
Conversation
mjac0bs
marked this pull request as ready for review
December 4, 2024 16:40
mjac0bs
requested review from
carrillo-erik and
hkhalil-akamai
and removed request for
a team
December 4, 2024 16:40
mjac0bs
force-pushed
the
M3-8961-adjust-pendo-url-path-sanitization
branch
from
December 4, 2024 16:42
c2e805f to
fb2ae7f
Compare
coliu-akamai
approved these changes
Dec 4, 2024
coliu-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ unit tests pass
✅ confirmed pendo urls now showing the %2A
thank you!
|
Coverage Report: ✅ |
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
|||||||||||||||||
bnussman-akamai
approved these changes
Dec 4, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 34m 37s |
| Commit |
|
| Committer | Mariah Jacobs |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
3
|
|
|
1
|
|
|
2
|
|
|
0
|
|
|
462
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
linode-config.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
|
rebuild-linode.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| rebuild linode > rebuilds a linode from Account StackScript |
Screenshots
Video
|
|
clone-linode.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| clone linode > can clone a Linode from Linode details page |
Screenshots
Video
|
|
cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Migrate Linode With Firewall > migrates linode with firewall - real data |
Screenshots
Video
|
|
This was referenced Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description 📝
UXR has reported:
"On our end, to ensure we are tracking accurately, we have to replace the
XXXXwith an<ignore>or*rule in the Pendo Tagging tool. Is there a way to replace it with a*? It will save manual steps in Pendo.. . once most pages have those bits replaced while retrotagging, we can make sure to look out forXXXXand replaced it in the Rule Builder with the attached screenshots."Even with rules configured, changing the
XXXXto*now will save time and speed up the tagging process in the future because new URLs will not have to have the same rules configured to transform theXXXXs.Note: We confirmed via Pendo that the unicode %2A wouldn't be an issue - the * in a rule will match the unicode in the normalized pattern.
Changes 🔄
XXXXstring with*in URL transformation and unit testTarget release date 🗓️
12/10
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅