test: [M3-8758]- Fixed delete-volume.spec.ts flaky test - #11365
Merged
harsh-akamai merged 2 commits intoDec 6, 2024
Merged
Conversation
harsh-akamai
changed the title
delete-volume.spec.ts flaky testdelete-volume.spec.ts flaky test
Cloud Manager UI test results🎉 465 passing tests on test run #2 ↗︎
|
jdamore-linode
approved these changes
Dec 4, 2024
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Thanks @harsh-akamai! Happy to re-review if you make any changes before taking this out of draft, but this is rock solid as-is. Ran the test 50 times and it passed every time 👍
harsh-akamai
marked this pull request as ready for review
December 5, 2024 06:11
harsh-akamai
requested review from
AzureLatte,
carrillo-erik and
hana-akamai
and removed request for
a team
December 5, 2024 06:11
hana-akamai
approved these changes
Dec 5, 2024
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 28m 16s |
| Commit |
|
| Committer | Harsh Shankar Rao |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
466
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
The test doesn't wait for the Volume to finish being created before attempting to delete.
Changes 🔄
Target release date 🗓️
12/12
How to test 🧪
delete-volume.spec.tstest usingyarn cy:debugAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅