Skip to content

fix: [M3-8972] - Overflow issue in Kubernetes Summary section on smaller screens (→ staging) - #11380

Merged
jaalah-akamai merged 2 commits into
linode:stagingfrom
pmakode-akamai:M3-8972-fix-overflow-issue-on-kubernetes-summary-for-smaller-screens
Dec 10, 2024
Merged

jaalah-akamai merged 2 commits into
linode:stagingfrom
pmakode-akamai:M3-8972-fix-overflow-issue-on-kubernetes-summary-for-smaller-screens

Conversation

@pmakode-akamai

@pmakode-akamai pmakode-akamai commented Dec 6, 2024 •

Copy link
Copy Markdown
Contributor

Description 📝

This PR fixes a minor regression in CM (mobile view/smaller screens only) caused by #11179

Note

Pointing this PR to staging

Preview 📷

Before After
Screenshot 2024-12-06 at 4 18 32 PM Screenshot 2024-12-06 at 5 18 07 PM

Changes 🔄

  • Fixed Summary section Overflow issue
  • Fixed "Summary" header alignment (made responsive)
  • Fixed text alignments and made some other improvements

How to test 🧪

  • Ensure no overflow issue in the "Summary" section on smaller devices
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai self-assigned this Dec 6, 2024
@pmakode-akamai pmakode-akamai added the Bug Fixes for regressions or bugs label Dec 6, 2024
@pmakode-akamai
pmakode-akamai marked this pull request as ready for review December 6, 2024 10:43
@pmakode-akamai
pmakode-akamai requested a review from a team as a code owner December 6, 2024 10:43
@pmakode-akamai
pmakode-akamai requested review from abailly-akamai and dwiley-akamai and removed request for a team December 6, 2024 10:43
@pmakode-akamai pmakode-akamai changed the title fix: [M3-8972] - overflow issue on kubernetes summary for smaller screens fix: [M3-8972] - Overflow issue on kubernetes summary for smaller screens Dec 6, 2024
@pmakode-akamai pmakode-akamai changed the title fix: [M3-8972] - Overflow issue on kubernetes summary for smaller screens fix: [M3-8972] - Overflow issue in Kubernetes Summary section on smaller screens Dec 6, 2024
@pmakode-akamai
pmakode-akamai force-pushed the M3-8972-fix-overflow-issue-on-kubernetes-summary-for-smaller-screens branch from a5fc3a6 to 5841ba2 Compare December 6, 2024 15:14
@pmakode-akamai
pmakode-akamai requested a review from a team as a code owner December 6, 2024 15:14
@pmakode-akamai
pmakode-akamai requested review from jdamore-linode and removed request for a team December 6, 2024 15:14
@pmakode-akamai
pmakode-akamai marked this pull request as draft December 6, 2024 15:17
@pmakode-akamai
pmakode-akamai changed the base branch from staging to develop December 6, 2024 15:20
@pmakode-akamai
pmakode-akamai marked this pull request as ready for review December 6, 2024 15:20
@github-actions

github-actions Bot commented Dec 6, 2024 •

Copy link
Copy Markdown

Coverage Report: ✅
Base Coverage: 86.85%
Current Coverage: 86.85%

dwiley-akamai
dwiley-akamai previously approved these changes Dec 6, 2024

@dwiley-akamai dwiley-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overflow issues fixed ✅

You may be able to point this PR at staging to get the fix in for next week's release. cc @hkhalil-akamai

@pmakode-akamai
pmakode-akamai changed the base branch from develop to staging December 7, 2024 07:34
@pmakode-akamai
pmakode-akamai dismissed dwiley-akamai’s stale review December 7, 2024 07:34

The base branch was changed.

@pmakode-akamai
pmakode-akamai changed the base branch from staging to develop December 7, 2024 07:34
@pmakode-akamai
pmakode-akamai force-pushed the M3-8972-fix-overflow-issue-on-kubernetes-summary-for-smaller-screens branch from 5841ba2 to 48b23fe Compare December 7, 2024 08:06
@pmakode-akamai
pmakode-akamai changed the base branch from develop to staging December 7, 2024 08:07
@pmakode-akamai pmakode-akamai changed the title fix: [M3-8972] - Overflow issue in Kubernetes Summary section on smaller screens fix: [M3-8972] - Overflow issue in Kubernetes Summary section on smaller screens (→ staging) Dec 7, 2024
@pmakode-akamai

Copy link
Copy Markdown
Contributor Author

@dwiley-akamai @hkhalil-akamai The PR is now pointing to → staging. This change requires re-approval.

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 466 passing tests on test run #19 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing466 Passing2 Skipped109m 40s

@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Dec 10, 2024
@jaalah-akamai
jaalah-akamai merged commit 500475c into linode:staging Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants