Skip to content

fix: [UIE-8228] - Database Resize: text update - #11406

Merged
cpathipa merged 3 commits into
linode:developfrom
mpolotsk-akamai:UIE-8228-downsizing-update-tooltip
Dec 13, 2024
Merged

cpathipa merged 3 commits into
linode:developfrom
mpolotsk-akamai:UIE-8228-downsizing-update-tooltip

Conversation

@mpolotsk-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Database Resize: Disabled plan tooltip updated for new databases, and updated plan selection descriptions.

Changes 🔄

  • Database Resize: Updated disabled plan tooltip for new database
  • Database Resize: Updated plan selection descriptions for new database
  • Database Resize > Summary Section : Updated text

Target release date 🗓️

01/14/2025

Preview 📷

Before After
Screenshot 2024-12-12 at 3 03 27 PM Screenshot 2024-12-12 at 3 02 56 PM
Screenshot 2024-12-12 at 3 04 03 PM Screenshot 2024-12-12 at 3 03 55 PM
Screenshot 2024-12-12 at 3 05 33 PM Screenshot 2024-12-12 at 3 05 39 PM

How to test 🧪

Prerequisites

  • dbaasV2 feature flag set to GA

Verification steps

(How to verify changes)

  • Choose a new database
  • Navigate to the Database Resize tab
  • Description in the Current Summary section is updated
  • Scroll down to the Plan Selection table
  • Hover over the tooltip for a disabled plan and confirm the text is updated
  • Scroll down to the Summary section and check that the text for nodes is updated
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mpolotsk-akamai
mpolotsk-akamai requested a review from a team as a code owner December 12, 2024 14:15
@mpolotsk-akamai
mpolotsk-akamai requested review from abailly-akamai and hkhalil-akamai and removed request for a team December 12, 2024 14:15
@jaalah-akamai jaalah-akamai added the DBaaS Relates to Database as a Service label Dec 12, 2024
Comment thread packages/manager/src/features/Databases/DatabaseCreate/DatabaseSummarySection.tsx Outdated
@github-actions

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 86.99%
Current Coverage: 86.99%

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 469 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing469 Passing2 Skipped103m 54s

@abailly-akamai abailly-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! thanks for the contribution

Code Quality, Copy and UI ✅

@cpathipa
cpathipa requested review from cpathipa and removed request for hkhalil-akamai December 13, 2024 16:13

@cpathipa cpathipa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

@cpathipa
cpathipa merged commit fcb4ec3 into linode:develop Dec 13, 2024
@cypress

cypress Bot commented Dec 13, 2024

Copy link
Copy Markdown

Cloud Manager E2E    Run #6969

Run Properties:  status check failed Failed #6969  •  git commit fcb4ec314f: fix: [UIE-8228] - Database Resize: text update (#11406)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6969
Run duration 32m 42s
Commit git commit fcb4ec314f: fix: [UIE-8228] - Database Resize: text update (#11406)
Committer mpolotsk-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 464
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/rebuild-linode.spec.ts • 2 failed tests

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Community StackScript Screenshots Video
rebuild linode > rebuilds a linode from Account StackScript Screenshots Video
Flakiness  linode-config.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Linode Config management > Mocked > Creates a new config using non-recommended settings and confirm the informational notices Screenshots Video
Flakiness  resize-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
resize linode > resizes a linode by decreasing size Screenshots Video
Flakiness  clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > can clone a Linode from Linode details page Screenshots Video
Flakiness  search-linodes.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Search Linodes > create a linode and make sure it shows up in the table and is searchable in main search tool Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DBaaS Relates to Database as a Service

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants