Skip to content

change: [UIE-8194] DBaaS Settings maintenance pending updates tooltip should have accurate tooltip text - #11417

Merged
cpathipa merged 1 commit into
linode:developfrom
smans-akamai:UIE-8194-dbaas-settings-maintenance-tooltip-text-fix
Dec 13, 2024
Merged

cpathipa merged 1 commit into
linode:developfrom
smans-akamai:UIE-8194-dbaas-settings-maintenance-tooltip-text-fix

Conversation

@smans-akamai

@smans-akamai smans-akamai commented Dec 13, 2024

Copy link
Copy Markdown
Contributor

Description 📝

This pull request is for a small change in the DBaaS Settings maintenance field. It updates the text used for the tooltip that gets displayed next to the Upgrade Version button when the button is disabled due to pending maintenance updates.

Changes 🔄

  • Text is changed to "Upgrades are disabled due to pending maintenance updates. To enable the upgrade, apply available updates now or wait until the next maintenance window."

Target release date 🗓️

1/14/25

Preview 📷

Before After
maintenance-tooltip-before maintenance-tooltip-after-2

How to test 🧪

Prerequisites

  • Managed Databases
  • dbaasV2 feature flag set for GA
  • Use mock data so you can view the pending updates state reliably, or have a Default DB created e.g. postgresql 13 with pending updates available

Verification steps

  • For a new database cluster that has pending updates available. Access that Database Cluster Details and navigate to Settings.
  • View the Maintenance field in Settings and there will be a tooltip visible next to the disabled Upgrade Version button.
  • Hover over this field to view the updated text.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@smans-akamai
smans-akamai requested a review from a team as a code owner December 13, 2024 17:32
@smans-akamai
smans-akamai requested review from abailly-akamai and mjac0bs and removed request for a team December 13, 2024 17:32
@smans-akamai
smans-akamai force-pushed the UIE-8194-dbaas-settings-maintenance-tooltip-text-fix branch from 0320db4 to b9f9fae Compare December 13, 2024 17:35

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending typo is fixed and CI passes. Thanks @smans-akamai!

@mjac0bs mjac0bs added the DBaaS Relates to Database as a Service label Dec 13, 2024
@smans-akamai
smans-akamai force-pushed the UIE-8194-dbaas-settings-maintenance-tooltip-text-fix branch from b9f9fae to a59a8c9 Compare December 13, 2024 17:54
@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Dec 13, 2024
@mjac0bs
mjac0bs requested a review from cpathipa December 13, 2024 17:57
@cpathipa
cpathipa removed the request for review from abailly-akamai December 13, 2024 18:01
@smans-akamai
smans-akamai requested a review from mjac0bs December 13, 2024 18:03
@github-actions

github-actions Bot commented Dec 13, 2024

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 86.99%
Current Coverage: 86.99%

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 466 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing466 Passing2 Skipped96m 45s

@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 13, 2024
@cpathipa
cpathipa merged commit 6bb0a17 into linode:develop Dec 13, 2024
@cypress

cypress Bot commented Dec 13, 2024

Copy link
Copy Markdown

Cloud Manager E2E    Run #6971

Run Properties:  status check passed Passed #6971  •  git commit 6bb0a17481: change: [UIE-8194] DBaaS Settings maintenance pending updates tooltip should hav...
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6971
Run duration 27m 17s
Commit git commit 6bb0a17481: change: [UIE-8194] DBaaS Settings maintenance pending updates tooltip should hav...
Committer smans-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 466
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants