test: [M3-8996] - Add test for LKE cluster rename flow - #11444
Closed
AzureLatte wants to merge 2 commits into
Closed
AzureLatte wants to merge 2 commits into
AzureLatte wants to merge 2 commits into
Conversation
AzureLatte
requested review from
jdamore-linode
and removed request for
a team
December 19, 2024 18:11
AzureLatte
requested review from
dwiley-akamai and
harsh-akamai
and removed request for
a team
December 19, 2024 18:14
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
|||||||||||||||||
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
lke-update.spec.ts passes locally & in CI ✅
linode-config.spec.ts failed in CI and I got a couple of failures when running it locally, seems to be flakiness or some intermittent API issues.
We'll also need to resolve the conflict in lke-update.spec.ts
jdamore-linode
approved these changes
Dec 31, 2024
Contributor
There was a problem hiding this comment.
Thanks @AzureLatte! Tests look great and pass reliably
Edit: pending conflict Dajahi pointed out!
4 tasks
Contributor
|
Closing this in favor of #11482 which is the same code but with merge conflicts fixed. Wasn't able to push the merge conflicts directly to @AzureLatte's branch since the GH auth changes. cc @dwiley-akamai |
This was referenced Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add a Cypress integration test using mock data to confirm that the LKE cluster rename flow works as expected.
Changes 🔄
List any change(s) relevant to the reviewer.
How to test 🧪
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅