Repository navigation
test: [M3-9030] - Object Storage Gen2 Warning Notice Missing Region Names for Unavailable Regions - #11530
Merged
jaalah-akamai merged 5 commits intoJan 24, 2025
Conversation
dmcintyr-akamai
requested review from
jdamore-linode
and removed request for
a team
January 16, 2025 17:42
dmcintyr-akamai
requested review from
hkhalil-akamai and
pmakode-akamai
and removed request for
a team
January 17, 2025 16:47
|
Coverage Report: ✅ |
jdamore-linode
approved these changes
Jan 17, 2025
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Thanks @dmcintyr-akamai, these are solid! Posted a couple pretty trivial suggestions, but functionally the tests are in great shape as-is and are passing reliably for me.
Let me know if you have any questions or thoughts about anything below 👍
pmakode-akamai
approved these changes
Jan 21, 2025
bnussman-akamai
changed the title
bnussman-akamai
changed the title
mjac0bs
changed the title
hkhalil-akamai
added
Approved
hkhalil-akamai
approved these changes
Jan 22, 2025
hkhalil-akamai
left a comment
hkhalil-akamai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @dmcintyr-akamai!
Aside: fill in or remove unnecessary sections from the PR description to make it more digestible.
Cloud Manager UI test results🎉 476 passing tests on test run #3 ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Added 2 integration tests to test for presence of warning notice.
Changes 🔄
List any change(s) relevant to the reviewer.
How to test 🧪
Prerequisites
(How to setup test environment)
Run tests in packages/manager/cypress/e2e/core/objectStorageGen2/bucket-object-gen2.spec.ts. 2 additional tests will be present.
As an Author, before moving this PR from Draft to Open, I confirmed ✅