Repository navigation
feat: [M3-8717] - Improve region filter loading state in Linodes Landing - #11550
Merged
hana-akamai merged 5 commits intoJan 27, 2025
Merged
hana-akamai merged 5 commits into
hana-akamai merged 5 commits into
Conversation
hana-akamai
marked this pull request as ready for review
January 22, 2025 23:02
hana-akamai
requested review from
bnussman-akamai,
dmcintyr-akamai,
dwiley-akamai and
hasyed-akamai
and removed request for
a team
January 22, 2025 23:02
dwiley-akamai
approved these changes
Jan 24, 2025
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
delete-placement-groups.spec.ts passes locally & in CI ✅
Code review ✅
Loading state observed when filtering by region type on Linodes landing page ✅
hasyed-akamai
approved these changes
Jan 27, 2025
hasyed-akamai
left a comment
hasyed-akamai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @hana-akamai! Everything works fine, no regressions. Looks good to go! 🚀
hasyed-akamai
added
Approved
|
Coverage Report: ✅ |
Cloud Manager UI test results🎉 482 passing tests on test run #4 ↗︎
|
Cloud Manager E2E
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 32m 38s |
| Commit |
|
| Committer | Hana Xu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
2
|
Passing
|
479
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/core/nodebalancers/smoke-create-nodebal.spec.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| create NodeBalancer > creates a NodeBalancer in a region with base pricing |
Screenshots
Video
|
|
linodes/resize-linode.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| resize linode > resizes a linode by increasing size: warm migration |
Screenshots
Video
|
|
linodes/linode-config.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Linode Config management > End-to-End > Boots a config |
Screenshots
Video
|
|
domains/smoke-create-domain-records.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Tests for Editable Domain CAA Records > Validates that "iodef" domain records returns error with invalid record |
Screenshots
Video
|
|
placementGroups/delete-placement-groups.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Placement Group deletion > can delete with Linodes assigned when unexpected error show up and retry |
Screenshots
Video
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Follow-up to #10639 (review)
Add a small loading state when the user is switching between different region filters
Changes 🔄
placeholderData: keepPreviousDataloading fix inuseAllLinodesQueryPreview 📷
list.view.before.mov
list.view.after.mov
summary.view.before.mov
summary.view.after.mov
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅