fix: Cypress tests failing in Github Actions, fix `resize-linode.spec.ts` failure, address `DatabaseBackups.test.tsx` flake by bnussman-akamai · Pull Request #11561 · linode/manager

bnussman-akamai · 2025-01-23T21:18:59Z

Description 📝

An attempt to fix our failing Cypress test that run in Github Actions
- I believe the issue was caused by a chrome update. It seems the issue started happening on runs that use Chrome 132 (example). Things worked on Chrome 131 (example).
- Chrome 132 no longer supports the old headless mode according to this post so this PR removes the old headless mode flag we were using
- This issue is not happening in our Jenkins cypress pipeline because that uses an older Chrome version that I believe is included in the cypress docker image
Skips the flakey tests in DatabaseBackups.test.tsx
- It has gotten out of hand
- I can't take it anymore 😖 In my opinion it is hurting us more than it is helping us
Fixes resize-linode.spec.ts failure caused by an API change

Preview 📷

How to test 🧪

I am able to reproduce with yarn cy:run locally and this change fixes the issue
- We should just confirm that this doesn't cause any regressions like "indefinite test hanging". This is why this extra config was added in the first place
Because the e2e Github Actions only runs on develop, staging, and master I can't easily test this
- I think we just have to merge and hope, but let me know if you have ideas on how to test this

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All unit tests are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

github-actions · 2025-01-23T22:16:07Z

Coverage Report: ✅
Base Coverage: 79.04%
Current Coverage: 79.04%

bnussman-akamai · 2025-01-23T23:37:55Z

      cy.wait('@linodeResize');
      cy.contains(
-        "Your linode will be warm resized and will automatically attempt to power off and restore to it's previous state."
+        "Your linode will be warm resized and will automatically attempt to power off and restore to its previous state."


This message comes from the /v4/account/notifications endpoint. The API team changed it's to its in API PR #7365

bnussman-akamai · 2025-01-23T23:38:07Z

    };

-    // Disable Chrome's new headless implementation.
-    // This attempts to resolve indefinite test hanging.


I haven't seen any hanging so far 🤞

linode-gh-bot · 2025-01-24T05:28:28Z

Cloud Manager UI test results

🎉 480 passing tests on test run #5 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`0 Failing`	`480 Passing`	`2 Skipped`	`93m 52s`

abailly-akamai

Thanks! looks good and we can monitor and see if there's any issue arising.

I have also noticed how much longer it takes for the coverage jobs to run.. I don't think it used to take that long?

abailly-akamai · 2025-01-24T15:13:20Z

+ * 1. https://github.com/linode/manager/pull/11130
+ * 2. https://github.com/linode/manager/pull/11394
+ */
+describe.skip('Database Backups (Legacy)', () => {


I think you can just delete it. I fully support this 😄

bnussman-akamai · 2025-01-24T15:33:36Z

@abailly-akamai I think 17 min is pretty typical now. I looked back in time a bit. It was closer to 15 minutes about 2 months ago https://github.com/linode/manager/actions/runs/11917205050

dwiley-akamai

Hopefully this fixes it 🤞🏾

cypress · 2025-01-24T16:13:51Z

Cloud Manager E2E Run #7123

Run Properties: Passed #7123 • c92372c062: fix: Cypress tests failing in Github Actions, fix `resize-linode.spec.ts` failur...

Project	`Cloud Manager E2E`
Branch Review	`develop`
Run status	`Passed #7123`
Run duration	`28m 17s`
Commit	c92372c062: fix: Cypress tests failing in Github Actions, fix `resize-linode.spec.ts` failur...
Committer	`Banks Nussman`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`3`
Pending	`2`
Skipped	`0`
Passing	`482`
View all changes introduced in this branch ↗︎

don't use the old headless anymore

0b43c50

bnussman-akamai added e2e Indicates that a PR touches Cypress tests in some way github_actions Pull requests that update GitHub Actions code labels Jan 23, 2025

bnussman-akamai self-assigned this Jan 23, 2025

bnussman-akamai requested a review from a team as a code owner January 23, 2025 21:19

bnussman-akamai requested review from jdamore-linode and removed request for a team January 23, 2025 21:19

bnussman added 2 commits January 23, 2025 18:25

fix linode resize test due to api error response change

80fc61f

chanegsets

bcf7ffc

bnussman-akamai requested a review from a team as a code owner January 23, 2025 23:35

bnussman-akamai requested review from hkhalil-akamai and pmakode-akamai and removed request for a team January 23, 2025 23:35

bnussman-akamai commented Jan 23, 2025

View reviewed changes

bnussman-akamai changed the title ~~fix: Cypress tests in Github Actions~~ fix: Cypress tests failing in Github Actions and fix resize-linode.spec.ts failure Jan 23, 2025

I can't take it any longer

e000a6d

bnussman-akamai mentioned this pull request Jan 24, 2025

change: [M3-9159] - Enable Pendo based on OneTrust cookie consent #11564

Merged

4 of 18 tasks

I'm going to rage

5a91188

bnussman-akamai changed the title ~~fix: Cypress tests failing in Github Actions and fix resize-linode.spec.ts failure~~ fix: Cypress tests failing in Github Actions, fix resize-linode.spec.ts failure, address DatabaseBackups.test.tsx flake Jan 24, 2025

abailly-akamai approved these changes Jan 24, 2025

View reviewed changes

dwiley-akamai self-requested a review January 24, 2025 15:29

jaalah-akamai approved these changes Jan 24, 2025

View reviewed changes

dwiley-akamai approved these changes Jan 24, 2025

View reviewed changes

bnussman-akamai merged commit c92372c into linode:develop Jan 24, 2025

hkhalil-akamai mentioned this pull request Feb 5, 2025

Release v1.136.0 - release → staging #11623

Merged

dwiley-akamai mentioned this pull request Feb 11, 2025

Release v1.136.0 - staging → master #11645

Merged

Navigation Menu

Repository navigation

fix: Cypress tests failing in Github Actions, fix `resize-linode.spec.ts` failure, address `DatabaseBackups.test.tsx` flake - #11561

fix: Cypress tests failing in Github Actions, fix `resize-linode.spec.ts` failure, address `DatabaseBackups.test.tsx` flake#11561
bnussman-akamai merged 5 commits into
linode:developfrom
bnussman-akamai:fix/cypress-chrome-not-working

bnussman-akamai commented Jan 23, 2025 •

edited by dwiley-akamai

Loading

Uh oh!

github-actions Bot commented Jan 23, 2025

Uh oh!

bnussman-akamai Jan 23, 2025

Uh oh!

bnussman-akamai Jan 23, 2025

Uh oh!

linode-gh-bot commented Jan 24, 2025

Uh oh!

abailly-akamai left a comment

Uh oh!

abailly-akamai Jan 24, 2025

Uh oh!

bnussman-akamai commented Jan 24, 2025

Uh oh!

dwiley-akamai left a comment

Uh oh!

cypress Bot commented Jan 24, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

bnussman-akamai commented Jan 23, 2025 • edited by dwiley-akamai Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description 📝

Preview 📷

How to test 🧪

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

Uh oh!

github-actions Bot commented Jan 23, 2025

Uh oh!

bnussman-akamai Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

linode-gh-bot commented Jan 24, 2025

Cloud Manager UI test results

🎉 480 passing tests on test run #5 ↗︎

Uh oh!

abailly-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

abailly-akamai Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

bnussman-akamai commented Jan 24, 2025

Uh oh!

dwiley-akamai left a comment

Choose a reason for hiding this comment

Uh oh!

cypress Bot commented Jan 24, 2025

Cloud Manager E2E Run #7123

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bnussman-akamai commented Jan 23, 2025 •

edited by dwiley-akamai

Loading