upcoming: [M3-9210] - Update Linode Interface types as specified - #11621
Merged
Merged
Conversation
coliu-akamai
marked this pull request as ready for review
February 5, 2025 21:26
coliu-akamai
requested review from
abailly-akamai,
bnussman-akamai and
carrillo-erik
and removed request for
a team
February 5, 2025 21:26
bnussman-akamai
approved these changes
Feb 6, 2025
abailly-akamai
approved these changes
Feb 7, 2025
coliu-akamai
force-pushed
the
m3-9210
branch
from
February 11, 2025 15:42
2bb361b to
9848b0a
Compare
|
Coverage Report: ✅ |
coliu-akamai
force-pushed
the
m3-9210
branch
from
February 19, 2025 19:23
9848b0a to
03045fb
Compare
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
|||||||||||||||||
carrillo-erik
approved these changes
Feb 20, 2025
Contributor
Author
|
API changes are all in - the last one to update the |
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 32m 45s |
| Commit |
|
| Committer | Connie Liu |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
4
|
|
|
3
|
|
|
0
|
|
|
523
|
| View all changes introduced in this branch ↗︎ | |
This was referenced Mar 6, 2025
This was referenced Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
addressesfield in public interface object toslaacwait to mergelabel on this PRHow to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅