Skip to content

refactor: [M3-9340] - Refactor CreateFirewallDrawer to use react-hook-form #11677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coliu-akamai merged 6 commits into from
Feb 20, 2025
Merged

refactor: [M3-9340] - Refactor CreateFirewallDrawer to use react-hook-form #11677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ff5b58
a lot of tweaks to that schema......
coliu-akamai Feb 15, 2025
6c331a0
convert createFirewallDrawer to react-hook-form
coliu-akamai Feb 15, 2025
f7fe183
error update
coliu-akamai Feb 15, 2025
e055079
changesets
coliu-akamai Feb 18, 2025
1989347
address feedback, investigate more
coliu-akamai Feb 18, 2025
4d77fb0
address feedback @abailly-akamai @dwiley-akamai
coliu-akamai Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/api-v4/.changeset/pr-11677-changed-1739995208483.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/api-v4": Changed
---

Make `label` field in `CreateFirewallPayload` required ([#11677](https://github.com/linode/manager/pull/11677))
4 changes: 2 additions & 2 deletions packages/api-v4/src/firewalls/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,14 @@ export interface FirewallTemplate {
}

export interface CreateFirewallPayload {
label?: string;
label: string;
Comment thread
coliu-akamai marked this conversation as resolved.
Outdated
tags?: string[];
rules: UpdateFirewallRules;
devices?: {
linodes?: number[];
nodebalancers?: number[];
interfaces?: number[];
};
} | null;
}

export interface UpdateFirewallPayload {
Expand Down
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-11677-tech-stories-1739897652667.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tech Stories
---

Refactor CreateFirewallDrawer to use `react-hook-form` ([#11677](https://github.com/linode/manager/pull/11677))
Loading