Skip to content

feat: [M3-9204] - Make Public checkbox default-checked in OAuth App Creation Form #11681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carrillo-erik merged 4 commits into from
Feb 21, 2025
Merged

feat: [M3-9204] - Make Public checkbox default-checked in OAuth App Creation Form #11681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
910833b
feat: [M3-9204] - Make Public checkbox default-checked in OAuth App C…
carrillo-erik Feb 18, 2025
d3017e2
Add changeset
carrillo-erik Feb 18, 2025
4a06d58
Update e2e tests to reflect Public checkbox as checked by default
carrillo-erik Feb 20, 2025
dc3c6b0
Merge branch 'develop' of https://github.com/linode/manager into feat…
carrillo-erik Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/manager/.changeset/pr-11681-changed-1739908630049.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Changed
---

Make "Public" checkbox default-checked in OAuth App creation form ([#11681](https://github.com/linode/manager/pull/11681))
4 changes: 2 additions & 2 deletions packages/manager/cypress/e2e/core/account/oauth-apps.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ const createOAuthApp = (oauthApp: OAuthClient) => {
cy.findByLabelText('Callback URL').click();
cy.focused().clear();
cy.focused().type(oauthApp.redirect_uri);
// Check the 'public' checkbox
if (oauthApp.public) {
// Uncheck the 'public' checkbox
if (!oauthApp.public) {
cy.get('[data-qa-checked]').should('be.visible').click();
}
mockCreateOAuthApp(oauthApp).as('createOauthApp');
Expand Down
8 changes: 8 additions & 0 deletions packages/manager/src/features/Profile/OAuthClients/CreateOAuthClientDrawer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,14 @@ describe('Create API Token Drawer', () => {
getByText('Create');
getByText('Cancel');
});
it('Should have the Public checkbox as checked by default', () => {
const { getByRole } = renderWithTheme(
<CreateOAuthClientDrawer {...props} />
);

const checkbox = getByRole('checkbox', { name: 'Public' });
expect(checkbox).toBeChecked();
});
it('Should show client side validation errors', async () => {
const { getByText } = renderWithTheme(
<CreateOAuthClientDrawer {...props} />
Expand Down
2 changes: 1 addition & 1 deletion packages/manager/src/features/Profile/OAuthClients/CreateOAuthClientDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const CreateOAuthClientDrawer = ({
const formik = useFormik<OAuthClientRequest>({
initialValues: {
label: '',
public: false,
public: true,
redirect_uri: '',
},
async onSubmit(values) {
Expand Down