Skip to content

test [M3-8070]: linting of images, kubernetes, linodes dirs - #11730

Merged
dmcintyr-akamai merged 6 commits into
linode:developfrom
dmcintyr-akamai:M3-8070_imagesKubeLinodes
Mar 3, 2025
Merged

dmcintyr-akamai merged 6 commits into
linode:developfrom
dmcintyr-akamai:M3-8070_imagesKubeLinodes

Conversation

@dmcintyr-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Fix linting errors in 3 additional directories.

Changes 🔄

Removed the overrides for these directories from the eslintrc file. Most of the changes involved unchaining the click/clear/type functions, which was easily done by inserting "cy.focused() before the improperly chained method. Also unchained method after scrollIntoView() by repeating the get. So a statement such as:
cy.get('myElement').scrollIntoView().within()
became:

cy.get('myElement').scrollIntoView();
cy.get('myElement').within()

How to test 🧪

yarn run lint

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Commit message and pull request title format standards

Note: Remove this section before opening the pull request
Make sure your PR title and commit message on squash and merge are as shown below

<commit type>: [JIRA-ticket-number] - <description>

Commit Types:

  • feat: New feature for the user (not a part of the code, or ci, ...).
  • fix: Bugfix for the user (not a fix to build something, ...).
  • change: Modifying an existing visual UI instance. Such as a component or a feature.
  • refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.
  • test: New tests or changes to existing tests. Does not change the production code.
  • upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.

Example: feat: [M3-1234] - Allow user to view their login history


@dmcintyr-akamai
dmcintyr-akamai marked this pull request as ready for review February 27, 2025 16:11
@dmcintyr-akamai
dmcintyr-akamai requested review from a team as code owners February 27, 2025 16:11
@dmcintyr-akamai
dmcintyr-akamai requested review from cliu-akamai, cpathipa, dwiley-akamai and jdamore-linode and removed request for a team February 27, 2025 16:11
@github-actions

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 80.18%
Current Coverage: 80.17%

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 2 failing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing530 Passing3 Skipped123m 29s

Details

Failing Tests
SpecTest
smoke-community-stackscripts.spec.tsCommunity Stackscripts integration tests » pagination works with infinite scrolling
timerange-verification.spec.tsIntegration tests for verifying Cloudpulse custom and preset configurations » Implement and validate the functionality of the custom date and time picker for selecting a specific date and time range

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts,cypress/e2e/core/cloudpulse/timerange-verification.spec.ts"

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Mar 3, 2025
@bnussman-akamai

Copy link
Copy Markdown
Member

Looks good! The failing tests I see are known to be flakey, so I think we're good

@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Mar 3, 2025

@linode-gh-bot linode-gh-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David!

@jdamore-linode jdamore-linode left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David!

Sorry about that 🤦‍♂️

@dmcintyr-akamai
dmcintyr-akamai merged commit deb8915 into linode:develop Mar 3, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Mar 3, 2025
@dmcintyr-akamai
dmcintyr-akamai deleted the M3-8070_imagesKubeLinodes branch March 3, 2025 16:02
@cypress

cypress Bot commented Mar 3, 2025

Copy link
Copy Markdown

Cloud Manager E2E    Run #7328

Run Properties:  status check passed Passed #7328  •  git commit deb8915f89: test [M3-8070]: linting of images, kubernetes, linodes dirs (#11730)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7328
Run duration 30m 30s
Commit git commit deb8915f89: test [M3-8070]: linting of images, kubernetes, linodes dirs (#11730)
Committer dmcintyr-akamai
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 532
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge!

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants