Skip to content

refactor: [M3-9419] - Migrate hooks to (at)linode/utilities package - #11770

Merged
pmakode-akamai merged 3 commits into
linode:developfrom
pmakode-akamai:M3-9419-migrate-hooks-to-utilities-package
Mar 7, 2025
Merged

pmakode-akamai merged 3 commits into
linode:developfrom
pmakode-akamai:M3-9419-migrate-hooks-to-utilities-package

Conversation

@pmakode-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Move the hooks (with no external dependencies) & its associated tests to @linode/utilities package

Changes 🔄

  • Moved
    • useDebouncedValue
    • useFormValidateOnChange
    • useScript
    • usePrevious
    • useSet
  • Moved associated tests to @linode/utilities package

Target release date 🗓️

N/A

How to test 🧪

  • Confirm all checks pass
  • Ensure all unit tests pass in @linode/utilities
  • Confirm all the necessary imports are updated
  • Confirm nothing on CM breaks:
    • Ensure everything works as expected wherever the above hooks are used
    • Ensure all tests pass in CM
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai self-assigned this Mar 3, 2025
@pmakode-akamai pmakode-akamai changed the title refactor: [M3-9419] - Migrate hooks to @linode/utilities package refactor: [M3-9419] - Migrate hooks to @linode/utilities package Mar 3, 2025
@pmakode-akamai
pmakode-akamai marked this pull request as ready for review March 3, 2025 12:53
@pmakode-akamai
pmakode-akamai requested a review from a team as a code owner March 3, 2025 12:53
@pmakode-akamai
pmakode-akamai requested review from hana-akamai and hasyed-akamai and removed request for a team March 3, 2025 12:53
@pmakode-akamai pmakode-akamai changed the title refactor: [M3-9419] - Migrate hooks to @linode/utilities package refactor: [M3-9419] - Migrate hooks to (at)linode/utilities package Mar 3, 2025

@hasyed-akamai hasyed-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pmakode-akamai 🚢

@hasyed-akamai hasyed-akamai added the Add'tl Approval Needed Waiting on another approval! label Mar 4, 2025

@hkhalil-akamai hkhalil-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hasyed-akamai!

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Mar 4, 2025
@hkhalil-akamai hkhalil-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 4, 2025
@pmakode-akamai
pmakode-akamai force-pushed the M3-9419-migrate-hooks-to-utilities-package branch from a00b8c8 to 2dc43ce Compare March 7, 2025 05:35
@github-actions

github-actions Bot commented Mar 7, 2025

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 80.14%
Current Coverage: 80.13%

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 536 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing536 Passing3 Skipped114m 31s

@pmakode-akamai
pmakode-akamai merged commit 14577bf into linode:develop Mar 7, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Mar 7, 2025
@cypress

cypress Bot commented Mar 7, 2025

Copy link
Copy Markdown

Cloud Manager E2E    Run #7365

Run Properties:  status check passed Passed #7365  •  git commit 14577bf022: refactor: [M3-9419] - Migrate hooks to `(at)linode/utilities` package (#11770)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7365
Run duration 31m 22s
Commit git commit 14577bf022: refactor: [M3-9419] - Migrate hooks to `(at)linode/utilities` package (#11770)
Committer Purvesh Makode
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 3
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 536
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Modularization

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants