refactor: [M3-9266] - Make RegionSelect pure

packages/manager/.changeset/pr-11790-removed-1741678858029.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Removed
+---
+
+Move `ListItemOption` from `manager` to `ui` package ([#11790](https://github.com/linode/manager/pull/11790))

packages/manager/.changeset/pr-11790-removed-1741678912235.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Removed
+---
+
+Move `regionsData` from `manager` to `utilities` package ([#11790](https://github.com/linode/manager/pull/11790))

packages/manager/.changeset/pr-11790-removed-1742396865376.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Removed
+---
+
+Move `LinodeCreateType` to `utilities` package ([#11790](https://github.com/linode/manager/pull/11790))

packages/manager/.changeset/pr-11790-tech-stories-1741678788058.md

@@ -0,0 +1,5 @@
+---
+"@linode/manager": Tech Stories
+---
+
+Make `RegionSelect` and `RegionMultiSelect` pure ([#11790](https://github.com/linode/manager/pull/11790))

packages/manager/cypress/component/components/region-select.spec.tsx

@@ -1,3 +1,4 @@
+import { accountAvailabilityFactory, regionFactory } from '@linode/utilities';
 import * as React from 'react';
 import { mockGetAccountAvailability } from 'support/intercepts/account';
 import { ui } from 'support/ui';
@@ -6,7 +7,6 @@ import { createSpy } from 'support/util/components';
 import { componentTests, visualTests } from 'support/util/components';
 
 import { RegionSelect } from 'src/components/RegionSelect/RegionSelect';
-import { accountAvailabilityFactory, regionFactory } from 'src/factories';
 
 componentTests('RegionSelect', (mount) => {
   beforeEach(() => {
@@ -26,6 +26,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability="Object Storage"
+            flags={{}}
             onChange={() => {}}
             regions={[region]}
             value={undefined}
@@ -54,6 +55,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability="Object Storage"
+            flags={{}}
             onChange={() => {}}
             regions={[region]}
             value={undefined}
@@ -83,6 +85,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability="Object Storage"
+            flags={{}}
             onChange={() => {}}
             regions={[region]}
             value={undefined}
@@ -112,6 +115,7 @@ componentTests('RegionSelect', (mount) => {
             <span id="other-element">Other Element</span>
             <RegionSelect
               currentCapability="Object Storage"
+              flags={{}}
               onChange={() => {}}
               regions={[region]}
               value={undefined}
@@ -145,6 +149,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability={undefined}
+            flags={{}}
             onChange={() => {}}
             regions={regions}
             value={undefined}
@@ -179,6 +184,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability={undefined}
+            flags={{}}
             onChange={() => {}}
             regions={regions}
             value={regionToPreselect.id}
@@ -214,6 +220,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability={undefined}
+            flags={{}}
             onChange={() => {}}
             regions={regions}
             value={regionToSelect.id}
@@ -241,6 +248,7 @@ componentTests('RegionSelect', (mount) => {
           <RegionSelect
             currentCapability={undefined}
             disableClearable={true}
+            flags={{}}
             onChange={() => {}}
             regions={regions}
             value={regionToSelect.id}
@@ -260,6 +268,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability={undefined}
+            flags={{}}
             onChange={() => {}}
             regions={regions}
             value={undefined}
@@ -277,6 +286,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability={undefined}
+            flags={{}}
             onChange={spyFn}
             regions={regions}
             value={undefined}
@@ -301,6 +311,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability={undefined}
+            flags={{}}
             onChange={spyFn}
             regions={regions}
             value={regionToSelect.id}
@@ -345,6 +356,7 @@ componentTests('RegionSelect', (mount) => {
       mount(
         <RegionSelect
           currentCapability="Object Storage"
+          flags={{}}
           onChange={() => {}}
           regions={regions}
           value={undefined}
@@ -379,6 +391,7 @@ componentTests('RegionSelect', (mount) => {
       mount(
         <RegionSelect
           currentCapability="Object Storage"
+          flags={{}}
           onChange={() => {}}
           regions={regions}
           value={undefined}
@@ -408,6 +421,7 @@ componentTests('RegionSelect', (mount) => {
       mount(
         <RegionSelect
           currentCapability={undefined}
+          flags={{}}
           onChange={() => {}}
           regions={regions}
           value={undefined}
@@ -438,6 +452,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability={undefined}
+            flags={{}}
             onChange={() => {}}
             regions={regions}
             value={undefined}
@@ -450,6 +465,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability={undefined}
+            flags={{}}
             onChange={() => {}}
             regions={regions}
             value={selectedRegion.id}
@@ -462,6 +478,7 @@ componentTests('RegionSelect', (mount) => {
         mount(
           <RegionSelect
             currentCapability={undefined}
+            flags={{}}
             onChange={() => {}}
             regions={regions}
             value={selectedRegion.id}

packages/manager/cypress/e2e/core/cloudpulse/alert-show-details.spec.ts

@@ -4,7 +4,7 @@
  * This file contains Cypress tests that validate the display and content of the  Alerts Show Detail Page in the CloudPulse application.
  * It ensures that all alert details, criteria, and resource information are displayed correctly.
  */
-import { capitalize } from '@linode/utilities';
+import { capitalize, regionFactory } from '@linode/utilities';
 import {
   aggregationTypeMap,
   dimensionOperatorTypeMap,
@@ -28,7 +28,6 @@ import {
   alertRulesFactory,
   databaseFactory,
   notificationChannelFactory,
-  regionFactory,
 } from 'src/factories';
 import { formatDate } from 'src/utilities/formatDate';
 

packages/manager/cypress/e2e/core/cloudpulse/cloudpulse-dashboard-errors.spec.ts

@@ -1,6 +1,7 @@
 /**
  * @file Error Handling Tests for CloudPulse Dashboard.
  */
+import { regionFactory } from '@linode/utilities';
 import { widgetDetails } from 'support/constants/widgets';
 import { mockGetAccount } from 'support/intercepts/account';
 import {
@@ -32,7 +33,6 @@ import {
   dashboardFactory,
   dashboardMetricFactory,
   databaseFactory,
-  regionFactory,
   widgetFactory,
 } from 'src/factories';
 

packages/manager/cypress/e2e/core/cloudpulse/create-user-alert.spec.ts

@@ -2,6 +2,7 @@
  * @fileoverview Cypress test suite for the "Create Alert" functionality.
  */
 
+import { regionFactory } from '@linode/utilities';
 import { statusMap } from 'support/constants/alert';
 import { widgetDetails } from 'support/constants/widgets';
 import { mockGetAccount } from 'support/intercepts/account';
@@ -26,7 +27,6 @@ import {
   databaseFactory,
   memoryRulesFactory,
   notificationChannelFactory,
-  regionFactory,
   triggerConditionFactory,
 } from 'src/factories';
 import { formatDate } from 'src/utilities/formatDate';

packages/manager/cypress/e2e/core/cloudpulse/dbaas-widgets-verification.spec.ts

@@ -1,6 +1,7 @@
 /**
  * @file Integration Tests for CloudPulse Dbass Dashboard.
  */
+import { regionFactory } from '@linode/utilities';
 import { widgetDetails } from 'support/constants/widgets';
 import { mockGetAccount } from 'support/intercepts/account';
 import {
@@ -27,7 +28,6 @@ import {
   databaseFactory,
   kubeLinodeFactory,
   linodeFactory,
-  regionFactory,
   widgetFactory,
 } from 'src/factories';
 import { generateGraphData } from 'src/features/CloudPulse/Utils/CloudPulseWidgetUtils';

packages/manager/cypress/e2e/core/cloudpulse/edit-system-alert.spec.ts

@@ -4,6 +4,7 @@
  * This file contains Cypress tests for the Edit Alert page of the CloudPulse application.
  * It ensures that users can navigate to the Edit Alert Page and that alerts are correctly displayed and interactive on the Edit page.
  */
+import { regionFactory } from '@linode/utilities';
 import { mockGetAccount } from 'support/intercepts/account';
 import {
   mockGetAlertDefinitions,
@@ -15,12 +16,7 @@ import { mockAppendFeatureFlags } from 'support/intercepts/feature-flags';
 import { mockGetRegions } from 'support/intercepts/regions';
 import { ui } from 'support/ui';
 
-import {
-  accountFactory,
-  alertFactory,
-  databaseFactory,
-  regionFactory,
-} from 'src/factories';
+import { accountFactory, alertFactory, databaseFactory } from 'src/factories';
 
 import type { Alert, Database } from '@linode/api-v4';
 import type { Flags } from 'src/featureFlags';

packages/manager/cypress/e2e/core/cloudpulse/edit-user-alert.spec.ts

@@ -5,6 +5,7 @@
  * It verifies that alert details are correctly displayed, interactive, and editable.
  */
 
+import { regionFactory } from '@linode/utilities';
 import {
   EVALUATION_PERIOD_DESCRIPTION,
   METRIC_DESCRIPTION_DATA_FIELD,
@@ -36,7 +37,6 @@ import {
   databaseFactory,
   memoryRulesFactory,
   notificationChannelFactory,
-  regionFactory,
   triggerConditionFactory,
 } from 'src/factories';
 import { formatDate } from 'src/utilities/formatDate';

packages/manager/cypress/e2e/core/cloudpulse/linode-widget-verification.spec.ts

@@ -1,6 +1,7 @@
 /**
  * @file Integration Tests for CloudPulse Linode Dashboard.
  */
+import { regionFactory } from '@linode/utilities';
 import { widgetDetails } from 'support/constants/widgets';
 import { mockGetAccount } from 'support/intercepts/account';
 import {
@@ -25,7 +26,6 @@ import {
   dashboardMetricFactory,
   kubeLinodeFactory,
   linodeFactory,
-  regionFactory,
   widgetFactory,
 } from 'src/factories';
 import { generateGraphData } from 'src/features/CloudPulse/Utils/CloudPulseWidgetUtils';

packages/manager/cypress/e2e/core/cloudpulse/timerange-verification.spec.ts

@@ -1,6 +1,7 @@
 /**
  * @file Integration Tests for CloudPulse Custom and Preset Verification
  */
+import { regionFactory } from '@linode/utilities';
 import { DateTime } from 'luxon';
 import { widgetDetails } from 'support/constants/widgets';
 import { mockGetAccount } from 'support/intercepts/account';
@@ -29,7 +30,6 @@ import {
   dashboardMetricFactory,
   databaseFactory,
   profileFactory,
-  regionFactory,
   widgetFactory,
 } from 'src/factories';
 import { convertToGmt } from 'src/features/CloudPulse/Utils/CloudPulseDateTimePickerUtils';

packages/manager/cypress/e2e/core/firewalls/migrate-linode-with-firewall.spec.ts

@@ -1,9 +1,9 @@
 /* eslint-disable sonarjs/no-duplicate-string */
+import { regionFactory } from '@linode/utilities';
 import {
   createLinodeRequestFactory,
   firewallFactory,
   linodeFactory,
-  regionFactory,
 } from '@src/factories';
 import { authenticate } from 'support/api/authentication';
 import {

packages/manager/cypress/e2e/core/general/gdpr-agreement.spec.ts

@@ -1,4 +1,5 @@
-import { linodeFactory, regionFactory } from '@src/factories';
+import { regionFactory } from '@linode/utilities';
+import { linodeFactory } from '@src/factories';
 import { mockGetAccountAgreements } from 'support/intercepts/account';
 import { mockCreateLinode } from 'support/intercepts/linodes';
 import { mockGetRegions } from 'support/intercepts/regions';

packages/manager/cypress/e2e/core/images/manage-image-regions.spec.ts

@@ -1,3 +1,4 @@
+import { regionFactory } from '@linode/utilities';
 import {
   mockGetCustomImages,
   mockGetImage,
@@ -8,7 +9,7 @@ import { mockGetRegions } from 'support/intercepts/regions';
 import { ui } from 'support/ui';
 import { extendRegion } from 'support/util/regions';
 
-import { imageFactory, regionFactory } from 'src/factories';
+import { imageFactory } from 'src/factories';
 
 import type { Image, Region } from '@linode/api-v4';
 

packages/manager/cypress/e2e/core/kubernetes/lke-create.spec.ts

@@ -1,7 +1,7 @@
 /**
  * @file LKE creation end-to-end tests.
  */
-import { pluralize } from '@linode/utilities';
+import { pluralize, regionFactory } from '@linode/utilities';
 import {
   dcPricingDocsLabel,
   dcPricingDocsUrl,
@@ -52,7 +52,6 @@ import {
   linodeTypeFactory,
   lkeHighAvailabilityTypeFactory,
   nodePoolFactory,
-  regionFactory,
 } from 'src/factories';
 import {
   CLUSTER_TIER_DOCS_LINK,

packages/manager/cypress/e2e/core/linodes/create-linode-in-core-region.spec.ts

@@ -1,3 +1,4 @@
+import { regionFactory } from '@linode/utilities';
 import { mockAppendFeatureFlags } from 'support/intercepts/feature-flags';
 import { mockCreateLinode } from 'support/intercepts/linodes';
 import {
@@ -8,7 +9,7 @@ import { ui } from 'support/ui';
 import { linodeCreatePage } from 'support/ui/pages';
 import { randomLabel, randomString } from 'support/util/random';
 
-import { linodeFactory, regionFactory } from 'src/factories';
+import { linodeFactory } from 'src/factories';
 
 describe('Create Linode in a Core Region', () => {
   /*

packages/manager/cypress/e2e/core/linodes/create-linode-in-distributed-region.spec.ts

@@ -1,3 +1,4 @@
+import { regionFactory } from '@linode/utilities';
 import { mockAppendFeatureFlags } from 'support/intercepts/feature-flags';
 import {
   mockCreateLinode,
@@ -12,7 +13,7 @@ import { linodeCreatePage } from 'support/ui/pages';
 import { randomLabel, randomString } from 'support/util/random';
 import { extendRegion } from 'support/util/regions';
 
-import { linodeFactory, linodeTypeFactory, regionFactory } from 'src/factories';
+import { linodeFactory, linodeTypeFactory } from 'src/factories';
 
 import type { Region } from '@linode/api-v4';
 

packages/manager/cypress/e2e/core/linodes/create-linode-region-select.spec.ts

@@ -1,4 +1,4 @@
-import { regionFactory } from '@src/factories';
+import { regionFactory } from '@linode/utilities';
 import { mockGetRegions } from 'support/intercepts/regions';
 import { ui } from 'support/ui';
 import { extendRegion } from 'support/util/regions';