fix: [M3-9465] - Make LKE/LKE-E spacing tweaks - #11827
Conversation
e4ef12d to
18a5bb1
Compare
| heading="LKE" | ||
| onClick={() => handleClusterTierSelection('standard')} | ||
| subheadings={[StandardSubheadings]} | ||
| sxCardBase={{ padding: '16px' }} |
There was a problem hiding this comment.
We made this change as a one-off for these particular cards to give the text-heavy card more breathing room.
If we want to make this change to the base component styles, we could make that change instead. Worth noting: selection card styles were already recently updated to the 12px padding they have all around here.
There was a problem hiding this comment.
I also think that 16px seems a bit much, but deferred to UX for the cluster tier cards. I'll add the topic as a (low priority) cafe topic to see if there's consensus among the wider group.
One thing that might consistently help the text-heaviness more than base card padding is some padding between subheading list items.
|
Coverage Report: ✅ |
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
|||||||||||||||||
hkhalil-akamai
left a comment
There was a problem hiding this comment.
✅ Verified expected spacing around selection card.
✅ Verified expected spacing in labels and taints drawer.
✅ Found no regressions in the LKE cluster create flow and Labels and Taints drawer.
Thanks Mariah! 🚀
Cloud Manager E2E
|
||||||||||||||||||||||||||||
| Project |
Cloud Manager E2E
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 32m 28s |
| Commit |
|
| Committer | Mariah Jacobs |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
2
|
|
|
3
|
|
|
0
|
|
|
539
|
| View all changes introduced in this branch ↗︎ | |

Description 📝
This PR makes some minor spacing changes to improve some inconsistencies throughout LKE as requested by UX during review of LKE-E.
Changes 🔄
16pxall around and the space between the card heading and first subheading to4px8px)24px) and increase the spacing between the tables and the 'Add' buttons (12px)Target release date 🗓️
3/25
Preview 📷
How to test 🧪
Prerequisites
(How to setup test environment)
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅