Skip to content

deps: [M3-9470] - Update tsx, tsup, and vite to resolve esbuild dependabot alert - #11866

Merged
bnussman-akamai merged 5 commits into
linode:developfrom
bnussman-akamai:M3-9470-update-dependencies-for-esbuild-dependabot
Mar 18, 2025
Merged

bnussman-akamai merged 5 commits into
linode:developfrom
bnussman-akamai:M3-9470-update-dependencies-for-esbuild-dependabot

Conversation

@bnussman-akamai

@bnussman-akamai bnussman-akamai commented Mar 17, 2025

Copy link
Copy Markdown
Member

Description 📝

How to test 🧪

  • Checkout this PR
  • Run pnpm i
  • Use pnpm why -r esbuild to see which esbuild versions our repo uses
  • Verify we are using esbuild 0.25.0 or newer
    • I don't think this PR fixes all instances of older esbuild versions, but I figured we could start with this and then see where we're at after merging. For example, we'll probably need to update Storybook
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Mar 17, 2025
@bnussman-akamai bnussman-akamai self-assigned this Mar 17, 2025
@bnussman-akamai
bnussman-akamai requested a review from a team as a code owner March 17, 2025 20:29
@bnussman-akamai
bnussman-akamai requested review from bill-akamai and dwiley-akamai and removed request for a team March 17, 2025 20:29
@github-actions

github-actions Bot commented Mar 17, 2025

Copy link
Copy Markdown

Coverage Report:
Base Coverage: 79.82%
Current Coverage: 79.82%

@jaalah-akamai jaalah-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks for addressing these. As you said, there's most likely going to be remnants from what I can see.

Example:
Screenshot 2025-03-17 at 7 49 28 PM

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 539 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing539 Passing3 Skipped117m 57s

@bill-akamai bill-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bnussman-akamai,
FYI, I just handled this on linode/design-language-system#89 through the use of a resolution. But down to wait it out until all the parent packages update in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dependencies Pull requests that update a dependency file

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants