upcoming: [M3-9588] - Add VPC & Firewall section to LKE-E create flow

[mjac0bs]

Description 📝

This is an enhancement. The goal of the section is:

• Provide more notice about what the user can expect with LKE-E creation. The VPC and Firewall are not currently mentioned at all on the create flow, but they will be visible to the customer.
• Establish this new section now, with mention of defaults. In the future, this will be be updated to allow the user to configure these settings.

Changes 🔄

• Adds a new section for VPC & Firewall to the Create Cluster flow for LKE-E

Target release date 🗓️

4/8

Preview 📷

Before	After

How to test 🧪

Prerequisites

(How to setup test environment)

• LKE-E feature flag on and LKE customer tag on account (see project tracker)

Verification steps

(How to verify changes)

• Go to http://localhost:3000/kubernetes/create
• Confirm no new VPC & Firewall section is visible when the default LKE tier is selected
• Select LKE-E as your cluster tier
• Confirm the new section is visible
• Confirm that the new section looks evenly spaced when compared with the other sections. I adjusted some divider margins. The spacing on this form is messy due to the number of different sections rendering conditionally.

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All unit tests are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

[hana-akamai]

Wondering if we should name this section Networking instead? Similar to Linode Create

[mjac0bs]

Good call, thank you. Done in 10a2a3e, along with the capitalization change.

[hana-akamai]

@mjac0bs thoughts on also renaming the heading to Networking?

[mjac0bs]

Oh, I totally missed that. 🤦🏼‍♀️ Let me run it by Daniel really quick. I think the consistency with Linodes makes sense, but not sure if there's any context I'm missing.

Edit:

These are actually separate papers on the Linode Create flow.

[hana-akamai]

Oh with the Linode interfaces work, it's grouped (behind a feature flag)

[mjac0bs]

After talking with Daniel, we're going to leave this as-is for now ("VPC & Firewall"). There are a couple considerations:

• ACL has a networking component to it, too. It would be potentially confusing to have a designated "Networking" section and exclude it. If we made a Networking section, we should consider moving the ACL form fields inside. That refactor is out of scope of this PR.
• From the LKE side, does a section header titled "Networking" make sense in a kubernetes context? Is there other information that kubernetes users would either expect to see there or should see there in the future? Is "Networking" as section header a good. clear choice, long-term?

Together, this is reason to match the existing mocks for now and revisit this in discussion with LKE backend and Product as we build the section out.

[hasyed-akamai]

Approved pending changes. 🚀

[linode-gh-bot]

Cloud Manager UI test results

🔺 2 failing tests on test run #5 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
2 Failing	532 Passing	4 Skipped	115m 8s

Details

Failing Tests
	Spec	Test
❌	clone-linode.spec.ts	clone linode » can clone a Linode from Linode details page
❌	smoke-community-stackscripts.spec.ts	Community Stackscripts integration tests » pagination works with infinite scrolling

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts,cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts"