change: [M3-9408] - Remove min length validation for tag - #11944
Merged
hasyed-akamai merged 4 commits intoApr 9, 2025
Merged
hasyed-akamai merged 4 commits into
hasyed-akamai merged 4 commits into
Conversation
hasyed-akamai
marked this pull request as ready for review
April 1, 2025 11:29
hasyed-akamai
requested review from
carrillo-erik and
harsh-akamai
and removed request for
a team
April 1, 2025 11:29
hasyed-akamai
force-pushed
the
M3-9408-remove-min-validation-for-tag
branch
2 times, most recently
from
April 2, 2025 06:57
164ad00 to
67b5156
Compare
hasyed-akamai
force-pushed
the
M3-9408-remove-min-validation-for-tag
branch
3 times, most recently
from
April 7, 2025 10:09
84f76ea to
f9a65c1
Compare
Contributor
Author
|
Thanks @carrillo-erik for suggesting the unit test for the |
carrillo-erik
approved these changes
Apr 8, 2025
carrillo-erik
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding the suggested tests. I'm approving now just need to resolve merge conflicts.
hasyed-akamai
force-pushed
the
M3-9408-remove-min-validation-for-tag
branch
from
April 9, 2025 05:48
f9a65c1 to
da87fa8
Compare
Cloud Manager UI test results🎉 540 passing tests on test run #11 ↗︎
|
This was referenced Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR removes the validation requiring a minimum of 3 characters when adding tags. Additionally, it adds validation to handle the edge case where the tag is an empty string or contains only spaces (e.g.,
" ").Changes 🔄
" ").Target release date 🗓️
Preview 📷
BEFORE.mov
AFTER.mov
BEFORE.mov
AFTER.mov
How to test 🧪
Reproduction steps
" ").Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅