refactor: [M3-9614] - Move getUserTimeZone and its associated profile factories - #11955
Conversation
…ctories to `@linode/utilities`
…ctories to `@linode/utilities`
bill-akamai
left a comment
There was a problem hiding this comment.
Great job @pmakode-akamai - that was lot of files to update.
I do see failing tests though:
src/utilities/formatDate.test.ts
Test: "formatDate utility > Non-humanized dates > should be displayed in 24-hour ISO format"
src/components/DateTimeDisplay/DateTimeDisplay.test.tsx
Test: "DateTimeDisplay component > should not display the time"
Test: "DateTimeDisplay component > should display the time"
Test: "DateTimeDisplay component > should format the time based on the specified format only"
Test: "DateTimeDisplay component > should format the time based on the specified format only pt2"
Test: "DateTimeDisplay component > Non-humanized dates > should be displayed in 24-hour ISO format"
src/features/Databases/DatabaseLanding/DatabaseLanding.test.tsx
Test: "Database Table > should render database landing with empty state"
Test: "Database Table > should render logo in new databases tab"
src/features/Billing/BillingPanels/BillingActivityPanel/BillingActivityPanel.test.tsx
Test: "BillingActivityPanel > should display 'Account active since'"
…ed-profile-factories
|
Good catch, @bill-akamai! I’m not sure why there aren't any failures in CI, but I did notice test failures locally because I missed updating the mocks. Should be all set now ✅ |
…ed-profile-factories
Thanks @pmakode-akamai - I pulled the latest but am seeing 3 test failures still: |
…ed-profile-factories
@bill-akamai I wasn't able to reproduce those test failures locally, and it seems unrelated to the changes made in the PR. I re-ran all the tests on my end, and they all passed successfully. Could you try running |
That was successful. I thought I had done so before but everything is passing now - good to go! 👍 |
…ed-profile-factories
dwiley-akamai
left a comment
There was a problem hiding this comment.
Checks pass ✅
@linode/utilities unit tests pass ✅
Imports updated ✅
…ed-profile-factories
…ed-profile-factories
Cloud Manager UI test results🎉 540 passing tests on test run #11 ↗︎
|

Description 📝
Move
getUserTimeZoneand its associated profile factoriesChanges 🔄
getUserTimeZoneand associated profile factories from manager to utilities packageTarget release date 🗓️
N/A
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅