test: [M3-9716] - Disallow some regions from being used for Image upload tests - #11961
Merged
jdamore-linode merged 3 commits intoApr 4, 2025
Conversation
…ading Images during Cypress tests
jdamore-linode
requested review from
dmcintyr-akamai
and removed request for
a team
April 2, 2025 22:50
jdamore-linode
requested review from
dwiley-akamai and
pmakode-akamai
and removed request for
a team
April 2, 2025 22:52
Cloud Manager UI test results🎉 539 passing tests on test run #2 ↗︎
|
mjac0bs
approved these changes
Apr 3, 2025
mjac0bs
left a comment
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Thanks for doing this, Joe. Confirmed the test passes consistently 10+ times locally as well. 🧪
dwiley-akamai
approved these changes
Apr 3, 2025
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
Ran & passed twice locally + passes in CI ✅
pmakode-akamai
approved these changes
Apr 4, 2025
mjac0bs
added
Approved
This was referenced Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR aims to eliminate the flakiness we're seeing with all of the tests in
machine-image-upload.spec.ts.The failures occur when the test attempts to upload an Image to a region which supports OBJ Gen 2. These regions do not support Machine Image upload and always result in the API responding with a 500. See the Jira ticket comments for more information.
This PR addresses the test flake by manually excluding the affected regions from being used by the tests. With these changes in place, I was able to run the spec 10 times and have it pass every time.
Changes 🔄
chooseRegiongb-lon,au-mel, andsg-sin-2when choosing a region during Machine Image upload testsTarget release date 🗓️
N/A.
How to test 🧪
pnpm cy:run -s "cypress/e2e/core/images/machine-image-upload.spec.ts"We'll also double check the CI test results to confirm that the spec passed without any failed attempts.
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅