change: [M3-9655] - [Akamai Design System] Toast Component - #11962
Merged
bill-akamai merged 8 commits intoApr 8, 2025
Merged
Conversation
bill-akamai
changed the title
bill-akamai
changed the title
bill-akamai
marked this pull request as ready for review
April 3, 2025 19:50
bill-akamai
requested review from
dwiley-akamai and
hasyed-akamai
and removed request for
a team
April 3, 2025 19:50
dwiley-akamai
approved these changes
Apr 7, 2025
dwiley-akamai
left a comment
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
Toast variants look good ✅
No functionality regressions observed ✅
Code review ✅
Cloud Manager UI test results🎉 540 passing tests on test run #5 ↗︎
|
hasyed-akamai
approved these changes
Apr 8, 2025
hasyed-akamai
left a comment
hasyed-akamai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @bill-akamai 🚀 !
hasyed-akamai
added
Approved
5 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR conforms the toast / snackbar component to the new Akamai Design System specs.
Changes 🔄
Preview 📷
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅