upcoming:[DI-24445] - Remove or condition when empty

[ankita-akamai]

Description 📝

Remove or condition from xfilter when it is empty.

Changes 🔄

• Removed the or condition from xfilter when it is empty in filtering of /instances call

Target release date 🗓️

22 April 2025

Preview 📷

Before	After

How to test 🧪

Verification steps

• Go to metrics
• Open Networks tab(cmd+op+I) in chrome dev tools, select dashboard(choose linode dashboard), region, tags.
• For the linode/instances call fired just after this change, see the Xfilter header composition: It will be of form : {"+and":[{"region":"x"}],"+or":[{"tags":"y"},{"tags":"z"}]}.
• Unselect all tags, Xfilter will be of form: {"+and":[{"region":"x"}]}

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

• I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

• All unit tests are passing
• TypeScript compilation succeeded without errors
• Code passes all linting rules

---

[bill-akamai]

Thanks @ankita-akamai

For the linode/instances call fired just after this change, see the Xfilter header composition: It will be of form : {"+and":[{"region":"x"}],"+or":[{"tags":"y"},{"tags":"z"}]}.

This checked out for me. I saw {"+and":[{"region":"us-central"}],"+or":[{"tags":"test1"}]} ✅

Unselect all tags, Xfilter will be of form: {"+and":[{"region":"x"}]}

I didn't see it show as this format. For me, it was {"region":"us-central"} - is that incorrect ❓

[ankita-akamai]

Thanks @ankita-akamai

For the linode/instances call fired just after this change, see the Xfilter header composition: It will be of form : {"+and":[{"region":"x"}],"+or":[{"tags":"y"},{"tags":"z"}]}.

This checked out for me. I saw {"+and":[{"region":"us-central"}],"+or":[{"tags":"test1"}]} ✅

Unselect all tags, Xfilter will be of form: {"+and":[{"region":"x"}]}

I didn't see it show as this format. For me, it was {"region":"us-central"} - is that incorrect ❓

@bill-akamai this api call is coming from other component at the same time, it is correct as well. Just after refreshing the page, in mocks, you will be able to see the second instances call in networks tab as what i mentioned in screenshot. The reason why just after unselecting all tags, you were not able to see this call was because it was already fired a while ago when you first selected the region before selecting the tags and now you are getting data from cache. You should scroll in the networks call to see it or easier way is what i showed in video.

Screen.Recording.2025-04-07.at.9.49.38.PM.mov

[linode-gh-bot]

Cloud Manager UI test results

🎉 540 passing tests on test run #5 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
0 Failing	540 Passing	4 Skipped	100m 49s

[venkymano-akamai]

Merging since all checks passed