Skip to content

fix: [DI-24413] - Bug fixes on the dashboard UI - #11968

Merged
nikhagra-akamai merged 9 commits into
linode:developfrom
nikhagra-akamai:ui-bugs
Apr 9, 2025
Merged

fix: [DI-24413] - Bug fixes on the dashboard UI#11968
nikhagra-akamai merged 9 commits into
linode:developfrom
nikhagra-akamai:ui-bugs

Conversation

@nikhagra-akamai

@nikhagra-akamai nikhagra-akamai commented Apr 4, 2025

Copy link
Copy Markdown
Contributor

Description 📝

Below bugs fixed in the PR:

  1. docs icon is not aligned with global filter paper in dashboard
  2. Applied filters showing scroll bar on 2 rows
  3. Time duration was not retrieving from preferences.

Changes 🔄

List any change(s) relevant to the reviewer.

  1. Updated global filters to use correct preferences key
  2. Update layout in Cloud pulse dashboard landing component
  3. increased the height of applied filter box

Target release date 🗓️

April 22

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before After
Screenshot 2025-04-04 at 4 40 30 PM Screenshot 2025-04-04 at 4 39 45 PM
Screenshot 2025-04-04 at 5 05 47 PM Screenshot 2025-04-04 at 5 06 49 PM

How to test 🧪

  1. Switch to mock user
  2. Go to metric tab from the menu
  3. Check the docs icon & paper is aligned with global notice
  4. Select all the filters
  5. Collapse the filter button
  6. You'll see no scroll bar for the two rows but a scroll bar will be introduced in applied filter if third row is added.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@hana-akamai

Copy link
Copy Markdown
Contributor

I am not seeing any Database clusters
image

@nikhagra-akamai

Copy link
Copy Markdown
Contributor Author

I am not seeing any Database clusters image

is this issue with mock user? because I can see it perfectly fine.

@nikhagra-akamai

Copy link
Copy Markdown
Contributor Author

@hana-akamai @carrillo-erik can we the another approval

@carrillo-erik carrillo-erik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Docs icon is aligned with the page's paper and no scroll bars after collapsing the filter menu.

Screenshot 2025-04-08 at 1 33 43 PM

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Apr 8, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 540 passing tests on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing540 Passing4 Skipped108m 8s

@nikhagra-akamai
nikhagra-akamai merged commit 3a8838f into linode:develop Apr 9, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants