upcoming: [DI-24470] - Rename resources to entities in labels, placeholders and messages in cloudpulse alerting - #11977
Conversation
|
@cpathipa / @carrillo-erik / @dmcintyr-akamai , this should be good for another pass. Please take a look |
There was a problem hiding this comment.
Do we also need to update the "resources"/"resource" instances in the following files?
- Utils/FilterConfig.ts
- ResourceMultiSelect.tsx#L67
- ResourceMultiSelect.tsx#L85
- ResourceMultiSelect.tsx#L91
- EditAlertResourcesConfirmationDialog.tsx
Also, should the "resources/resource" in the test case titles (e.g., in EditAlertLanding.test.tsx#L17C18, etc) be updated for consistency with what we are testing in the test cases?
…amai/manager into resource_to_entities_linode
|
@pmakode-akamai , I have updated the message in EditAlertResourceConfirmationDialog and EditAlertLanding.test.tsx The FilterConfig is associated to dashboards and not related to alerts, so we will not be doing the changes there. |
pmakode-akamai
left a comment
There was a problem hiding this comment.
thanks for the changes, @venkymano-akamai - looks good!
✅ renamed resources to entities
✅ all tests pass
…entities_linode # Conflicts: # packages/manager/src/features/CloudPulse/Alerts/CreateAlert/Resources/CloudPulseModifyAlertResources.test.tsx
|
@dmcintyr-akamai / @jdamore-linode , can we check the cypress changes here, there are only changes for renaming and no changes in logic |
Cloud Manager UI test results🎉 540 passing tests on test run #15 ↗︎
|
|
Merging with enough approvals, jobs pass and cypress pass |
Description 📝
Rename resources to entities in labels, placeholders and messages in cloudpulse alerting create, edit and details flow.
Changes 🔄
Target release date 🗓️
10th April 2025 in alpha
Preview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅