upcoming: [DI-24451] - Added confirmation dialog on enabling/disabling of alert - #11981
Merged
nikhagra-akamai merged 19 commits intoApr 9, 2025
Merged
Conversation
nikhagra-akamai
requested review from
hasyed-akamai,
jdamore-linode and
mjac0bs
and removed request for
a team
April 7, 2025 16:47
mjac0bs
reviewed
Apr 7, 2025
Comment on lines
+14
to
+15
| const message = `Are you sure you want to disable the alert for ${entityName}?`; | ||
| const title = `Disable ${alert.label} Alert?`; |
Contributor
There was a problem hiding this comment.
Optional nit: these could be moved out of the test function to live with the constants above, since they're repeated in multiple tests. (And renamed something like disabledMessage, disabledTitle.)
…Confirmation dialogue boxes
| .should('be.visible') | ||
| .should('have.text', `${action} ${alertName} Alert?`); | ||
|
|
||
| cy.get('[data-qa-drawer="true"]') |
Contributor
There was a problem hiding this comment.
Suggested change
| cy.get('[data-qa-drawer="true"]') | |
| cy.get('[data-qa-drawer]') |
Can't this itself work?
Comment on lines
+357
to
+359
| action: 'Disable' | 'Enable'; | ||
| alertName: string; | ||
| alias: string; |
Contributor
There was a problem hiding this comment.
can we define a interface for this or it is not needed?
Contributor
Author
There was a problem hiding this comment.
instead of new interface I've reused already existing interface as partial
venkymano-akamai
approved these changes
Apr 8, 2025
Contributor
|
I've addressed all the comments. Please review it once more and let me know if the text can be further refined |
Comment on lines
+337
to
+353
| // verify dialog title | ||
| cy.get('[data-qa-drawer-title]') | ||
| .should('be.visible') | ||
| .should('have.text', `${action} ${alertName} Alert?`); | ||
|
|
||
| cy.get('[data-qa-drawer]') | ||
| .find('h6') | ||
| .should('be.visible') | ||
| .should('have.text', confirmationText); | ||
|
|
||
| ui.buttonGroup | ||
| .find() | ||
| .find('button') | ||
| .filter(`[label="${action}"]`) | ||
| .should('be.visible') | ||
| .should('be.enabled') | ||
| .click(); |
Contributor
There was a problem hiding this comment.
Suggested change
| // verify dialog title | |
| cy.get('[data-qa-drawer-title]') | |
| .should('be.visible') | |
| .should('have.text', `${action} ${alertName} Alert?`); | |
| cy.get('[data-qa-drawer]') | |
| .find('h6') | |
| .should('be.visible') | |
| .should('have.text', confirmationText); | |
| ui.buttonGroup | |
| .find() | |
| .find('button') | |
| .filter(`[label="${action}"]`) | |
| .should('be.visible') | |
| .should('be.enabled') | |
| .click(); | |
| ui.dialog | |
| .findByTitle(`${action} ${alertName} Alert?`) | |
| .should('be.visible') | |
| .within(() => { | |
| cy.findByText(confirmationText).should('be.visible'); | |
| ui.button | |
| .findByTitle(action) | |
| .should('be.visible') | |
| .should('be.enabled') | |
| .click(); | |
| }); |
- Check out our UI helpers
- You can use
.within(() => {}to limit the scope of your selections. That's preferable to chaining a bunch of filters. - There's no need to test minor markup details, like confirming that the confirmation text is inside an
h6.
Contributor
Author
There was a problem hiding this comment.
thanks for suggestion
jdamore-linode
approved these changes
Apr 8, 2025
Contributor
Author
|
@mjac0bs we got enough approvals & resolved your comments as well, if all good can we merge? |
nikhagra-akamai
added
Approved
Cloud Manager UI test results🎉 540 passing tests on test run #10 ↗︎
|
This was referenced Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Added the confirmation dialog while enabling & disabling of alert.
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
22nd April
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅