test [M3 9558]: replace hardcoded region id in clone linode test - #11992
Merged
jdamore-linode merged 6 commits intoApr 15, 2025
Conversation
dmcintyr-akamai
marked this pull request as ready for review
April 8, 2025 17:58
dmcintyr-akamai
requested review from
dwiley-akamai,
hkhalil-akamai and
jdamore-linode
and removed request for
a team
April 8, 2025 17:58
dwiley-akamai
approved these changes
Apr 8, 2025
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/resize-linode.spec.ts" |
|||||||||||||||||
jdamore-linode
approved these changes
Apr 11, 2025
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks @dmcintyr-akamai!
This was referenced Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Replaced the region IDs which were hardcoded and may not exist in all environments. The mock pricing data had hardcoded region IDs, so it was easier to mock the regions to include these hardcoded IDs (us-west, us-east).
Changes 🔄
Added mock regions for us-west and us-east.
How to test 🧪
pnpm run cy:e2e -s 'cypress/e2e/core/linodes/clone-linode.spec.ts'
(How to reproduce the issue, if applicable)
To repro the initial bug, run pnpm run cy:e2e -s 'cypress/e2e/core/linodes/clone-linode.spec.ts' in an environment that lacks us-west or us-east regions.
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅
Commit message and pull request title format standards
<commit type>: [JIRA-ticket-number] - <description>Commit Types:
feat: New feature for the user (not a part of the code, or ci, ...).fix: Bugfix for the user (not a fix to build something, ...).change: Modifying an existing visual UI instance. Such as a component or a feature.refactor: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.test: New tests or changes to existing tests. Does not change the production code.upcoming: A new feature that is in progress, not visible to users yet, and usually behind a feature flag.Example:
feat: [M3-1234] - Allow user to view their login history