change: [M3-9735] - Add encryption icon to Image edit drawer - #11993
Merged
bill-akamai merged 3 commits intoApr 8, 2025
Merged
Conversation
bill-akamai
changed the title
bill-akamai
marked this pull request as ready for review
April 8, 2025 18:29
bill-akamai
requested review from
abailly-akamai,
bnussman-akamai and
cpathipa
and removed request for
a team
April 8, 2025 18:29
Cloud Manager UI test results🔺 3 failing tests on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/object-storage-objects-multicluster.spec.ts,cypress/e2e/core/objectStorage/object-storage.e2e.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts" |
|||||||||||||||||||||||
bnussman-akamai
approved these changes
Apr 8, 2025
abailly-akamai
approved these changes
Apr 8, 2025
| <Stack direction="row" spacing={1} alignItems="center"> | ||
| <Lock /> | ||
| <Typography | ||
| sx={(theme) => ({ color: theme.textColors.textAccessTable })} |
Contributor
There was a problem hiding this comment.
Have you confirmed this is the right token to use? Not that I have a better suggestion 😄 , but the token name seems unintuitive considering the purpose.
Contributor
Author
There was a problem hiding this comment.
This appeared to be the closest we had. I don't believe we have a specific token for this grayish text label note (or whatever you'd call it 🤷).
This was referenced Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR adds the "Encrypted" label to the
EditImageDrawercomponent.Changes 🔄
Preview 📷
Verification steps
/imagesand create or find an existing custom image.Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅