Skip to content

feat: [UIE-8602] - IAM RBAC: new drawer for updating role for entity - #11998

Merged
cpathipa merged 6 commits into
linode:developfrom
aaleksee-akamai:UIE-8602-drawer-change-role-for-entity
Apr 15, 2025
Merged

feat: [UIE-8602] - IAM RBAC: new drawer for updating role for entity#11998
cpathipa merged 6 commits into
linode:developfrom
aaleksee-akamai:UIE-8602-drawer-change-role-for-entity

Conversation

@aaleksee-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Add a new drawer for updating role for entity

Changes 🔄

List any change(s) relevant to the reviewer.

  • add a new drawer
  • add logic if role doesn't have permissions to Permission component

Target release date 🗓️

(dev)

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before After
image image
image image

How to test 🧪

Prerequisites

(How to setup test environment)

  • Ensure the Identity and Access Beta flag is enabled in dev tools
  • use devenv and login as vagrant user
  • Click on the any username in the users table and go to the tab Assigned Entities or click on the user's menu View Assigned Entities
  • Click on action menu Change Role for the entity

Verification steps

(How to verify changes)

  • drawer renders
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@aaleksee-akamai
aaleksee-akamai requested a review from a team as a code owner April 9, 2025 13:32
@aaleksee-akamai
aaleksee-akamai requested review from bill-akamai and dwiley-akamai and removed request for a team April 9, 2025 13:32
@aaleksee-akamai aaleksee-akamai self-assigned this Apr 9, 2025
@aaleksee-akamai
aaleksee-akamai force-pushed the UIE-8602-drawer-change-role-for-entity branch from 578d4d3 to e0d528b Compare April 9, 2025 13:33
@cpathipa
cpathipa requested review from cpathipa and removed request for bill-akamai April 9, 2025 13:39

@cpathipa cpathipa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaleksee-akamai LGTM! confirming on the verification steps. ESLint warning should be resolved before merging this PR.

@cpathipa cpathipa added the Add'tl Approval Needed Waiting on another approval! label Apr 10, 2025
Comment thread packages/manager/src/features/IAM/Shared/utilities.ts Outdated
Comment thread packages/manager/src/features/IAM/Shared/utilities.ts Outdated
@aaleksee-akamai
aaleksee-akamai force-pushed the UIE-8602-drawer-change-role-for-entity branch from 68b1e68 to 3697a9c Compare April 11, 2025 11:04
@aaleksee-akamai

Copy link
Copy Markdown
Contributor Author

@aaleksee-akamai LGTM! confirming on the verification steps. ESLint warning should be resolved before merging this PR.

I've updated with fixing that, but some of the complaints like here AssignedEntitiesTable.tsx about Define a constant instead of duplicating this literal 4 times. for that line

 <TableCell sx={{ display: { sm: 'table-cell', xs: 'none' } }}>

do we need to do that also?

@aaleksee-akamai
aaleksee-akamai force-pushed the UIE-8602-drawer-change-role-for-entity branch from 63158d0 to d67847f Compare April 11, 2025 15:48

@corya-akamai corya-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks!

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Apr 11, 2025
@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Apr 11, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 1 failing test on test run #9 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing539 Passing4 Skipped116m 51s

Details

Failing Tests
SpecTest
rebuild-linode.spec.tsCloud Manager Cypress Tests→rebuild linode » rebuild linode

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/linodes/rebuild-linode.spec.ts"

@cpathipa
cpathipa merged commit e702ac7 into linode:develop Apr 15, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! IAM (Identity & Access Management)

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants