feat: [UIE-8602] - IAM RBAC: new drawer for updating role for entity - #11998
Merged
cpathipa merged 6 commits intoApr 15, 2025
Merged
Conversation
aaleksee-akamai
requested review from
bill-akamai and
dwiley-akamai
and removed request for
a team
April 9, 2025 13:32
aaleksee-akamai
force-pushed
the
UIE-8602-drawer-change-role-for-entity
branch
from
April 9, 2025 13:33
578d4d3 to
e0d528b
Compare
cpathipa
approved these changes
Apr 10, 2025
cpathipa
left a comment
Contributor
There was a problem hiding this comment.
@aaleksee-akamai LGTM! confirming on the verification steps. ESLint warning should be resolved before merging this PR.
aaleksee-akamai
force-pushed
the
UIE-8602-drawer-change-role-for-entity
branch
from
April 11, 2025 11:04
68b1e68 to
3697a9c
Compare
Contributor
Author
I've updated with fixing that, but some of the complaints like here do we need to do that also? |
6 tasks
aaleksee-akamai
force-pushed
the
UIE-8602-drawer-change-role-for-entity
branch
from
April 11, 2025 15:48
63158d0 to
d67847f
Compare
Cloud Manager UI test results🔺 1 failing test on test run #9 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/rebuild-linode.spec.ts" |
|||||||||||||||||
This was referenced Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add a new drawer for updating role for entity
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
(dev)
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Prerequisites
(How to setup test environment)
Assigned Entitiesor click on the user's menuView Assigned EntitiesChange Rolefor the entityVerification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅