test: [M3-9565] - mock region for linode config test - #11999
Merged
dmcintyr-akamai merged 3 commits intoApr 16, 2025
Merged
Conversation
dmcintyr-akamai
marked this pull request as ready for review
April 9, 2025 13:33
dmcintyr-akamai
requested review from
bnussman-akamai,
hkhalil-akamai and
jdamore-linode
and removed request for
a team
April 9, 2025 13:33
Cloud Manager UI test results🔺 2 failing tests on test run #3 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/kubernetes/lke-create.spec.ts" |
||||||||||||||||||||
bnussman-akamai
changed the title
bnussman-akamai
approved these changes
Apr 10, 2025
jdamore-linode
approved these changes
Apr 11, 2025
jdamore-linode
left a comment
jdamore-linode
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks @dmcintyr-akamai! I'm surprised you didn't have to also call mockGetRegions in these tests and pass the mock region to that, but they are passing thanks to these changes 🙌
hkhalil-akamai
approved these changes
Apr 16, 2025
This was referenced Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Replace hardcoded region with mock region because hardcoded region id does not exist in all environments.
Changes 🔄
Use regionFactory to mock region w/ the hardcoded region id.
How to test 🧪
pnpm run cy:e2e -s 'cypress/e2e/core/linodes/linode-config.spec.ts'
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅
--