change: [M3-9654] - Akamai Design System: Notice component - #12004
Merged
hana-akamai merged 10 commits intoApr 15, 2025
Merged
Conversation
hana-akamai
marked this pull request as ready for review
April 10, 2025 16:30
hana-akamai
requested review from
bill-akamai,
cpathipa and
pmakode-akamai
and removed request for
a team
April 10, 2025 16:30
cpathipa
approved these changes
Apr 10, 2025
bill-akamai
reviewed
Apr 14, 2025
bill-akamai
approved these changes
Apr 14, 2025
bill-akamai
left a comment
bill-akamai
left a comment
Contributor
There was a problem hiding this comment.
Looks good!
[x] Check notices and banners across the app
[x] Check storybook stories locally
harsh-akamai
added
Approved
|
Looks good, thank you! I have just one comment for a multi-line content inside a notice. Paddings on top/bottom should be unchanged depending on the number of text lines and always be the same. |
Cloud Manager UI test results🎉 540 passing tests on test run #8 ↗︎
|
4 tasks
This was referenced Apr 17, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Update Notice and Banner components to conform to the new Akamai Design System specifications
Changes 🔄
Preview 📷
before.mov
after.mov
How to test 🧪
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅