Skip to content

upcoming: [M3-9752] - Support more VPC features in the Add Interface Drawer - #12008

Merged
bnussman-akamai merged 9 commits into
linode:developfrom
bnussman-akamai:M3-9752-support-more-vpc-features-in-add-interface-drawer
Apr 14, 2025
Merged

upcoming: [M3-9752] - Support more VPC features in the Add Interface Drawer#12008
bnussman-akamai merged 9 commits into
linode:developfrom
bnussman-akamai:M3-9752-support-more-vpc-features-in-add-interface-drawer

Conversation

@bnussman-akamai

Copy link
Copy Markdown
Member

Description 📝

  • Supports more VPC features in the Add Interface Drawer
    • Ability to add VPC IPv4 Ranges
    • Ability to set a 1:1 NAT
  • What is not implemented
    • Choosing a reserved IP as the 1:1 NAT address
      • We should add this when we support reserved IPs
    • Ability to specify multiple VPC IPs
      • There is a hard limit of 1 on the backend currently

Preview 📷

Before After
Screenshot 2025-04-10 at 11 14 28 AM Screenshot 2025-04-10 at 11 14 00 AM

How to test 🧪

Prerequisites

  • Add new-interfaces-beta customer tag to your account
  • Enable Cloud Manager's Linode Interfaces feature flag

Verification steps

  • Create a Linode that uses Linode Interfaces
  • Go to that Linode's details page > Networking Tab
  • Test the "Add Network Interface" drawer in general
    • Verify the VPC section works as expected and supports all features except the ones called out in the Description
    • Test error handling in this drawer
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai
bnussman-akamai marked this pull request as ready for review April 10, 2025 21:17
@bnussman-akamai
bnussman-akamai requested review from a team as code owners April 10, 2025 21:17
@bnussman-akamai
bnussman-akamai requested review from abailly-akamai, coliu-akamai and jdamore-linode and removed request for a team April 10, 2025 21:17

@coliu-akamai coliu-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bnussman-akamai! looks awesome, just needs a changeset

✅ adding a VPC interface (with/without auto-assigning VPC IPv4 address, with/wihtout public IPv4 address, with/without ranges)
✅ error handling - general errors, IPv4 errors, only one public IPv4 error, vpc range errors

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 1 failing test on test run #6 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing539 Passing4 Skipped113m 50s

Details

Failing Tests
SpecTest
bucket-create-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster Bucket create » Object Storage Multicluster Bucket create

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/bucket-create-multicluster.spec.ts"

@jaalah jaalah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This is looking good - created VPC
✅ Auto-assigned
✅ Manual assignment
✅ Error state: The IP is not contained in the subnet

@jaalah-akamai jaalah-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My better-half tried approving for me :P

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Apr 14, 2025
@bnussman-akamai bnussman-akamai removed the Add'tl Approval Needed Waiting on another approval! label Apr 14, 2025
@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Apr 14, 2025
@bnussman-akamai
bnussman-akamai merged commit e753366 into linode:develop Apr 14, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Linode Interfaces

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants