change: [M3-9742] - Add dedicated Alerts tab on Linode details page - #12013
Merged
pmakode-akamai merged 5 commits intoApr 21, 2025
Merged
Conversation
pmakode-akamai
added
the
ACLP Integration
pmakode-akamai
marked this pull request as ready for review
April 11, 2025 12:57
pmakode-akamai
requested review from
cpathipa,
hana-akamai and
jaalah-akamai
and removed request for
a team
April 11, 2025 12:57
mjac0bs
reviewed
Apr 11, 2025
pmakode-akamai
requested review from
dmcintyr-akamai
and removed request for
a team
April 14, 2025 12:36
Cloud Manager UI test results🎉 540 passing tests on test run #9 ↗︎
|
dmcintyr-akamai
approved these changes
Apr 17, 2025
mjac0bs
approved these changes
Apr 17, 2025
mjac0bs
left a comment
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Thanks @pmakode-akamai.
✅ Confirmed URL route and tab are both Alert
✅ Confirmed no regressions to the existing alert behavior
✅ Confirmed disabled state looks good for a read only user
One observation of existing behavior: when the user clears the field rather than switching the threshold off, we (1) don't have validation messages on all the fields (just the first one), so we display less user-friendly API errors for the rest and (2) inputting a non-numerical value produces at least one error in the dev console. Not necessarily in scope of this PR, but worth consideration of a backlog item.
| Prod | This Branch |
|---|---|
 |
 |
|
All right so thank you for giving me this information now with what is
happening to me right now I'm based in Ghana and you know that um I don't
know what to say back they don't want me to register and login to my
account since I use my other virtual card so it has been banned but I I
would like to get a new uh MasterCard so I'll get it and now I'll be able
to register an account to a little then get scripting installation um I
need script installation for ssh, V2RAY and udp for Ghanaian users and also
I would like to link it to how to create a mobile application so our need
help from you so just help me with that
…On Thu, Apr 17, 2025, 9:59 PM Mariah Jacobs ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks @pmakode-akamai <https://github.com/pmakode-akamai>.
✅ Confirmed URL route and tab are both Alert
✅ Confirmed no regressions to the existing alert behavior
✅ Confirmed disabled state looks good for a read only user
Screenshot.2025-04-17.at.2.49.50.PM.jpg (view on web)
<https://github.com/user-attachments/assets/7470dde7-31dc-435f-82ca-9b3fd2c11d5d>
One observation of existing behavior: when the user clears the field
rather than switching the threshold off, we (1) don't have validation
messages on all the fields (just the first one), so we display less
user-friendly API errors for the rest and (2) inputting a non-numerical
value produces at least one error in the dev console. Not necessarily in
scope of this PR, but worth consideration of a backlog item.
Prod This Branch
Screenshot.2025-04-17.at.2.46.51.PM.jpg (view on web)
<https://github.com/user-attachments/assets/df401299-1085-4aa2-ac3a-3795c6cebe11> Screenshot.2025-04-17.at.2.46.28.PM.jpg
(view on web)
<https://github.com/user-attachments/assets/38e3fdeb-c45b-40fd-860c-4bb77dce2218>
—
Reply to this email directly, view it on GitHub
<#12013 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLCYPHOT25CWG5OULHK6R2L22AP4LAVCNFSM6AAAAAB26EJECGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDONZXGAYTSMZYHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
rodonnel-akamai
pushed a commit
to rodonnel-akamai/manager
that referenced
this pull request
Apr 23, 2025
…linode#12013) * Add dedicated Alerts tab on linode details page * Added changeset: Add dedicated `Alerts` tab on Linode details page * Update changeset * Update tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Add dedicated
Alertstab on Linode details page.Since this is a global change, no feature flag is required.
Changes 🔄
Alertstab and added a new route for this tabAlertstabAlertstabTarget release date 🗓️
N/A
Preview 📷
How to test 🧪
Alertstab appears in Linode detail navigationSettingstabAuthor Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅