refactor: [M3-9767] - Use simple Select in RegionTypeFilter - #12018
Merged
hkhalil-akamai merged 2 commits intoApr 15, 2025
Merged
Conversation
hkhalil-akamai
marked this pull request as ready for review
April 11, 2025 22:04
hkhalil-akamai
requested review from
abailly-akamai and
coliu-akamai
and removed request for
a team
April 11, 2025 22:04
Cloud Manager UI test results🔺 2 failing tests on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts,cypress/e2e/core/objectStorageMulticluster/bucket-create-multicluster.spec.ts" |
||||||||||||||||||||
abailly-akamai
approved these changes
Apr 14, 2025
harsh-akamai
approved these changes
Apr 15, 2025
harsh-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ Verify only Linodes in the selected Region type are displayed
✅ Refresh the page and verify the selection is maintained through local storage
Changes look good! Thanks @hkhalil-akamai
coliu-akamai
approved these changes
Apr 15, 2025
coliu-akamai
left a comment
Contributor
There was a problem hiding this comment.
thank you!
✅ confirmed testing instructions
Contributor
Author
|
Test failures appear unrelated. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Update
RegionTypeFilterto use the new basic Select component instead ofAutocomplete.Changes 🔄
RegionTypeFilterto use basic SelectregionFilterprop fromLinodesLandingWrapper>LinodesLanding>DisplayLinodesI invite feedback/suggestions for the best way to move forward.
Preview 📷
before.mov
after.mov
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅