refactor: [M3-9711] - Move grants and its associated factories to utilities package - #12025
Merged
hasyed-akamai merged 3 commits intoApr 16, 2025
Conversation
hasyed-akamai
force-pushed
the
M3-9711-move-grants-and-its-associated-grants-factories
branch
from
April 15, 2025 06:28
35fd4f4 to
b494130
Compare
hasyed-akamai
changed the title
grants and its associated factories to utilities package
hasyed-akamai
marked this pull request as ready for review
April 15, 2025 06:50
hasyed-akamai
requested review from
dmcintyr-akamai,
harsh-akamai and
mjac0bs
and removed request for
a team
April 15, 2025 06:51
Cloud Manager UI test results🎉 540 passing tests on test run #3 ↗︎
|
harsh-akamai
left a comment
harsh-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ All checks pass
✅ Units tests pass
Thanks @hasyed-akamai! 🚀
harsh-akamai
approved these changes
Apr 15, 2025
mjac0bs
approved these changes
Apr 15, 2025
mjac0bs
left a comment
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Migration looked good and CI is happy. Thanks @hasyed-akamai.
mjac0bs
added
Approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Move
grantsand its associated factories toutilitiespackageHow to test 🧪
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅