change: [M3-9433] - Image Service Gen2 GA: Update copy about Image Pricing - #12031
Conversation
mjac0bs
changed the title
mjac0bs
left a comment
mjac0bs
left a comment
There was a problem hiding this comment.
Approving because both spots looked good and matched the mocks.
Noted a couple of linter warnings for clean up and an argument for not including the icon on this notice.
There was a problem hiding this comment.
Seeing a couple of linter warnings in this file related to prop and import order. Can we fix those?
| preferenceKey={`manage-replicas-${image?.id}`} | ||
| spacingTop={16} | ||
| variant="info" | ||
| important |
There was a problem hiding this comment.
I'm not personally a huge fan of using the icon here. Based on the mock and what @hana-akamai mentioned during standup today, it sounds like this isn't displaying quite as expected with the new notices, but either way, the notice is dense with a lot of text in that small drawer, and imo it would look better without with i.
| Mocks | Without icon |
|---|---|
 |
 |
There was a problem hiding this comment.
Agreed, I think Alban is looking into that issue at component level.
Cloud Manager UI test results🔺 1 failing test on test run #6 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/rebuild-linode.spec.ts" |
|||||||||||||||||
bnussman-akamai
added
Approved
…icing (linode#12031) * change: [m3-9433] - Update copy about Image Pricing * Added changeset: Image Service Gen2 GA - Update copy about Image Pricing * Update ManageImageRegionsForm.tsx * Add info icon and make dismissible banner
5 participants
Description 📝
Image service Gen2 Copy updates.
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
4/22
Preview 📷
How to test 🧪
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅