fix: [M3-9770] - Fix incorrect max autoscaler limit validation for LKE-E - #12033
Merged
mjac0bs merged 8 commits intoApr 16, 2025
Merged
Conversation
added 6 commits
April 15, 2025 12:26
mjac0bs
force-pushed
the
M3-9770-fix-autoscaler-validation-for-lke-e
branch
from
April 15, 2025 19:33
290af8d to
7731411
Compare
mjac0bs
marked this pull request as ready for review
April 15, 2025 19:44
mjac0bs
requested review from
cpathipa,
dwiley-akamai and
jdamore-linode
and removed request for
a team
April 15, 2025 19:44
Cloud Manager UI test results🔺 2 failing tests on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/bucket-details-multicluster.spec.ts,cypress/e2e/core/linodes/rebuild-linode.spec.ts" |
||||||||||||||||||||
bnussman-akamai
approved these changes
Apr 16, 2025
dwiley-akamai
approved these changes
Apr 16, 2025
dwiley-akamai
left a comment
Contributor
There was a problem hiding this comment.
lke-update.spec.ts passes locally & in CI ✅
Existing validation for standard clusters ✅
Validation for LKE-E clusters ✅
hana-akamai
approved these changes
Apr 16, 2025
This was referenced Apr 17, 2025
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Current limit for LKE-E node pool autoscaler max is 100, when 500 is expected. This is because LKE-E allows up to 500 nodes in a node pool (and 500 nodes in a cluster) for initial LA launch.
Changes 🔄
Target release date 🗓️
4/22
Preview 📷
Screen.Recording.2025-04-15.at.12.34.02.PM.mov
How to test 🧪
Prerequisites
(How to setup test environment)
prod-test-004-fefor an account with an LKE-E cluster1000for testing purposesReproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅