test: [M3-9174] - Add Cypress tests for Firewall landing page improvements related to Linode Interfaces - #12040
Merged
jdamore-linode merged 6 commits intoApr 16, 2025
Conversation
jdamore-linode
requested review from
dmcintyr-akamai
and removed request for
a team
April 15, 2025 21:47
…rfaces improvements
jdamore-linode
requested review from
hana-akamai and
harsh-akamai
and removed request for
a team
April 15, 2025 21:48
coliu-akamai
approved these changes
Apr 16, 2025
coliu-akamai
left a comment
coliu-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ confirmed tests pass
tests look great, thanks Joe! 🎉
coliu-akamai
added
Add'tl Approval Needed
bnussman-akamai
approved these changes
Apr 16, 2025
bnussman-akamai
added
Approved
Cloud Manager UI test results🔺 1 failing test on test run #4 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/bucket-details-multicluster.spec.ts" |
|||||||||||||||||
This was referenced Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This adds a few new Firewall landing page tests to cover functionality added by the Linode Interfaces project.
Changes 🔄
landing-page-empty-state.spec.tstofirewall-landing-page.spec.tslists all Firewallsandlists default Firewallstests infirewall-landing-page.spec.tscannot delete default Firewallstest indelete-firewall.spec.tsmockGetFirewallSettingsmock utilTarget release date 🗓️
4/24
How to test 🧪
We can rely on CI for this. To run the tests locally, however, you can use this command:
pnpm cy:run -s "cypress/e2e/core/firewalls/delete-firewall.spec.ts,cypress/e2e/core/firewalls/firewall-landing-page.spec.ts"Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅