fix: [M3-9522] - Recovery images table headers alignment with data column - #12043
Merged
hasyed-akamai merged 4 commits intoApr 22, 2025
Conversation
hasyed-akamai
marked this pull request as ready for review
April 16, 2025 06:01
hasyed-akamai
requested review from
carrillo-erik,
coliu-akamai and
jdamore-linode
and removed request for
a team
April 16, 2025 06:01
hasyed-akamai
changed the title
hasyed-akamai
force-pushed
the
M3-9522-recovery-images-table-headers-not-aligned-with-data-column
branch
from
April 17, 2025 16:40
14ac203 to
19520a5
Compare
coliu-akamai
approved these changes
Apr 18, 2025
coliu-akamai
left a comment
coliu-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ confirmed test passes
✅ confirmed table headers match data in test
thanks @hasyed-akamai!
coliu-akamai
added
Add'tl Approval Needed
hasyed-akamai
force-pushed
the
M3-9522-recovery-images-table-headers-not-aligned-with-data-column
branch
from
April 21, 2025 04:39
43489ee to
1a07d17
Compare
carrillo-erik
approved these changes
Apr 21, 2025
carrillo-erik
left a comment
carrillo-erik
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Only suggestion is the phrasing of the changeset message but it's not a blocker. Just resolve the merge conflicts and you should be good to merge.
hasyed-akamai
force-pushed
the
M3-9522-recovery-images-table-headers-not-aligned-with-data-column
branch
from
April 22, 2025 02:04
71bc065 to
99e43a1
Compare
hasyed-akamai
added
Approved
Cloud Manager UI test results🔺 1 failing test on test run #7 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/stackscripts/smoke-community-stackscripts.spec.ts" |
|||||||||||||||||
rodonnel-akamai
pushed a commit
to rodonnel-akamai/manager
that referenced
this pull request
Apr 23, 2025
…lumn (linode#12043) * fix: [M3-9522] - Recovery images table headers alignment with data column * Added changeset: Recovery Images Table Header alignment with the data column * fix imports * change changeset type and description
This was referenced May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes the Recovery Images Table Header alignment with the data column in mock tests.
Changes 🔄
Target release date 🗓️
N/A
Preview 📷
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅