upcoming: [M3-9590] - Update Linode Networking UI for Linode Interfaces - #12049
Merged
bnussman-akamai merged 18 commits intoApr 21, 2025
Conversation
bnussman-akamai
marked this pull request as ready for review
April 16, 2025 22:08
bnussman-akamai
requested review from
bill-akamai and
pmakode-akamai
and removed request for
a team
April 16, 2025 22:08
bnussman-akamai
commented
Apr 16, 2025
| ); | ||
| }; | ||
|
|
||
| const StyledChip = styled(Chip)(({ theme }) => ({ |
Member
Author
There was a problem hiding this comment.
From what I could tell, this component is essentially visually broken right now, so I just reversed back to using a plain "Chip".
I checked the Akamai design system and didn't see anything resembling this component so I don't really know what we want it to look like. In my opinion, a plain chip is a safe bet for now, but open to feedback here.
bill-akamai
reviewed
Apr 17, 2025
bill-akamai
approved these changes
Apr 18, 2025
bill-akamai
left a comment
bill-akamai
left a comment
Contributor
There was a problem hiding this comment.
Looks good @bnussman-akamai - verified per description. ✅
coliu-akamai
approved these changes
Apr 18, 2025
coliu-akamai
left a comment
coliu-akamai
left a comment
Contributor
There was a problem hiding this comment.
✅ tested various things with Linode interfaces and networking
- confirmed add IP address button hidden in networking table for LI
- confirmed ip invalidation when adding/editing/deleting LI
- light and dark mode look good
- vpc text updated
- mask sensitive data
thanks @bnussman-akamai! 🚀
Cloud Manager UI test results🎉 565 passing tests on test run #13 ↗︎
|
rodonnel-akamai
pushed a commit
to rodonnel-akamai/manager
that referenced
this pull request
Apr 23, 2025
…es (linode#12049) * initial changes * polish things * add testing * remove interface suffixes * add some extra invalidations to fix table not updating when modifying an interface * improve form focus, forgot to commit on last PR * add some extra invalidations to fix table not updating when modifying an interface * add custom no options text for VPC select * invalidate linode interfaces when a range is deleted using range delete endpoint * invalidate linode interfaces when a range is deleted using range delete endpoint * fix up more cache invalidations * show support links for ip limits * feedback @bill-akamai * more invalidations @coliu-akamai * add similar VPC messaging in the Add Interface drawer --------- Co-authored-by: Banks Nussman <banks@nussman.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Main Changes
Add IP Addressbutton for Linodes using Linode Interfaces because you must add IPs on the Interface level now 🙈Deletebutton on IP address rows because the IP address must be deleted at the Interface level now tooShowMorecomponent style issues (colors are not easily visible in light and dark mode)Preview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅