test [M3-9569]: Fix for OBJ multicluster delete test app crash in DevCloud - #12085
Merged
dmcintyr-akamai merged 2 commits intoApr 22, 2025
Merged
Conversation
dmcintyr-akamai
requested review from
jdamore-linode
and removed request for
a team
April 22, 2025 15:50
dmcintyr-akamai
requested review from
abailly-akamai and
mjac0bs
and removed request for
a team
April 22, 2025 15:50
Cloud Manager UI test results🎉 565 passing tests on test run #2 ↗︎
|
abailly-akamai
approved these changes
Apr 22, 2025
abailly-akamai
left a comment
abailly-akamai
left a comment
Contributor
There was a problem hiding this comment.
Now for a proper GH user approval ✅
mjac0bs
added
Approved
This was referenced May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Fix OBJ multicluster delete test app crash in cypress/e2e/core/objectStorageMulticluster/bucket-delete-multicluster.spec.ts by ensuring an available region is used in the created cluster. Test fn objectStorageBucketFactory.build() defaults to using hardcoded region id of 'us-east' which is not available in all test environments.
Changes 🔄
List any change(s) relevant to the reviewer.
Ensure that objectStorageBucketFactory.build() uses an available region.
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅