Skip to content

change: [DI-24087] - Added last modified by & create date in list & detail - #12091

Merged
nikhagra-akamai merged 19 commits into
linode:developfrom
nikhagra-akamai:alert/last_modified_by
Apr 25, 2025
Merged

change: [DI-24087] - Added last modified by & create date in list & detail#12091
nikhagra-akamai merged 19 commits into
linode:developfrom
nikhagra-akamai:alert/last_modified_by

Conversation

@nikhagra-akamai

Copy link
Copy Markdown
Contributor

Description 📝

Added Last Modified By and create date for the alert in the alert list & details page.

Changes 🔄

List any change(s) relevant to the reviewer.

  1. Updated AlertListing component to include last_modified_by column
  2. Updated AlertDetailOverview component to include last_modified_by and create date

Target release date 🗓️

Next release cycle

Preview 📷

Include a screenshot or screen recording of the change.

🔒 Use the Mask Sensitive Data setting for security.

💡 Use <video src="" /> tag when including recordings in table.

Before After
Screenshot 2025-04-21 at 4 30 54 PM Screenshot 2025-04-21 at 4 30 36 PM
Screenshot 2025-04-21 at 4 31 05 PM Screenshot 2025-04-21 at 4 30 17 PM

How to test 🧪

  1. Switch to mock user
  2. Go to alerts tab
  3. In the alert list table a new column 'Last Modified By' is added
  4. Select a particular alert
  5. 2 New field 'Last Modified By' and 'Created' is added in alert detail
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@abailly-akamai abailly-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ✅

Please try to clean up some of those eslint warning - we've added them for a reason!

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager Apr 23, 2025
@nikhagra-akamai

Copy link
Copy Markdown
Contributor Author

Looks good ✅

Please try to clean up some of those eslint warning - we've added them for a reason!

Yes I've cleaned them up & Pushed

@bnussman-akamai bnussman-akamai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but should we be consider the user's selected timezone when rendering times/dates?

I think it's a good idea if Cloud Manager respects the users timezone wherever possible because we do that in most places in Cloud Manager

If we update the Cloud Manager code to respect the user's timezone, we should make sure we update our tests to account for the fact that the user profile's timezone

"@linode/manager": Added
---

add `Last Modified By` column in alert listing contants.ts, add `Last Modified By` value in AlertTableRow, add `Last Modified By` and `Created date` in AlertDetailOverview ([#12091](https://github.com/linode/manager/pull/12091))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think we can remove the word add here because this will already be grouped under the Added section when the changelog gets generated

@nikhagra-akamai

Copy link
Copy Markdown
Contributor Author

@bnussman-akamai if all good, is this PR good to merge?

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 1 failing test on test run #9 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing566 Passing5 Skipped108m 40s

Details

Failing Tests
SpecTest
bucket-create-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster Bucket create » Object Storage Multicluster Bucket create

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/bucket-create-multicluster.spec.ts"

@nikhagra-akamai

Copy link
Copy Markdown
Contributor Author

merging the PR as it has required approval.

@nikhagra-akamai
nikhagra-akamai merged commit f3d43a4 into linode:develop Apr 25, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants