change: [DI-24087] - Added last modified by & create date in list & detail - #12091
Conversation
…a in alert list & detail page
abailly-akamai
left a comment
There was a problem hiding this comment.
Looks good ✅
Please try to clean up some of those eslint warning - we've added them for a reason!
Yes I've cleaned them up & Pushed |
bnussman-akamai
left a comment
There was a problem hiding this comment.
Changes look good, but should we be consider the user's selected timezone when rendering times/dates?
I think it's a good idea if Cloud Manager respects the users timezone wherever possible because we do that in most places in Cloud Manager
If we update the Cloud Manager code to respect the user's timezone, we should make sure we update our tests to account for the fact that the user profile's timezone
| "@linode/manager": Added | ||
| --- | ||
|
|
||
| add `Last Modified By` column in alert listing contants.ts, add `Last Modified By` value in AlertTableRow, add `Last Modified By` and `Created date` in AlertDetailOverview ([#12091](https://github.com/linode/manager/pull/12091)) |
There was a problem hiding this comment.
It think we can remove the word add here because this will already be grouped under the Added section when the changelog gets generated
|
@bnussman-akamai if all good, is this PR good to merge? |
Cloud Manager UI test results🔺 1 failing test on test run #9 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/bucket-create-multicluster.spec.ts" |
|||||||||||||||||
|
merging the PR as it has required approval. |
Description 📝
Added Last Modified By and create date for the alert in the alert list & details page.
Changes 🔄
List any change(s) relevant to the reviewer.
Target release date 🗓️
Next release cycle
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅