Skip to content

change: [M3-9429] - Akamai Design System: Select Component - #12124

Merged
hasyed-akamai merged 25 commits into
linode:developfrom
hasyed-akamai:M3-9429-ads-select-component
May 30, 2025
Merged

change: [M3-9429] - Akamai Design System: Select Component#12124
hasyed-akamai merged 25 commits into
linode:developfrom
hasyed-akamai:M3-9429-ads-select-component

Conversation

@hasyed-akamai

@hasyed-akamai hasyed-akamai commented Apr 29, 2025

Copy link
Copy Markdown
Contributor

Description 📝

Update styles to match CDS for Select component

Changes 🔄

  • Add Select design tokens
  • Add more stories for the Select component in Storybook
  • Update styles to match CDS for Select component

Target release date 🗓️

N/A

Preview 📷

Some of the Select variants (from storybook):

State Light Dark
With Tooltip Text Light Dark
Label Position Left Light Dark
Label Position Top Light Dark

How to test 🧪

  • Confirm CI is passing
  • Checkout the branch and verify figma changes for Select component
    • Verify all the Select variants:
      • Default
      • Hover
      • Selected
      • Disabled
      • Readonly
      • Error
    • Verify spacing
    • Verify the Select component and its different variants in Storybook
  • Confirm no visual regression in application
    • Verify Select wherever used in CM (in both light and dark modes)
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@hasyed-akamai hasyed-akamai self-assigned this Apr 29, 2025
@hasyed-akamai
hasyed-akamai force-pushed the M3-9429-ads-select-component branch 3 times, most recently from 8e93a54 to e6ee690 Compare April 30, 2025 06:50
@hasyed-akamai hasyed-akamai changed the title initial commit change: [M3-9429] - Akamai Design System: Select Component Apr 30, 2025
@hasyed-akamai hasyed-akamai added Design Tokens Laying the groundwork for Design Tokens and removed Work in Progress labels Apr 30, 2025
@hasyed-akamai
hasyed-akamai force-pushed the M3-9429-ads-select-component branch from 17b1af3 to d46bec8 Compare April 30, 2025 10:40
@hasyed-akamai
hasyed-akamai marked this pull request as ready for review May 6, 2025 07:57
@hasyed-akamai
hasyed-akamai requested a review from a team as a code owner May 6, 2025 07:57
@hasyed-akamai
hasyed-akamai requested review from hana-akamai and harsh-akamai and removed request for a team May 6, 2025 07:57
@hana-akamai hana-akamai added the Requires UX Approval Design System Component Requires UX Approval label May 6, 2025
@hana-akamai hana-akamai added the Add'tl Approval Needed Waiting on another approval! label May 8, 2025

@harsh-akamai harsh-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. ✅

One tiny change
image

Padding left needs to be 12px instead of 30px

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager May 19, 2025
@hasyed-akamai hasyed-akamai added Do Not Merge Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels May 20, 2025
Comment thread packages/ui/src/foundations/themes/dark.ts
Comment thread packages/ui/src/foundations/themes/dark.ts Outdated
Comment thread packages/ui/src/foundations/themes/dark.ts Outdated
Comment thread packages/ui/src/foundations/themes/light.ts Outdated

@davyd-akamai davyd-akamai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember after our discussion the last thing that needed to be changed in this PR was the dropdown category typography — capitalized letters and a smaller font size. If that’s already been implemented, perfect!

@hasyed-akamai
hasyed-akamai force-pushed the M3-9429-ads-select-component branch from 014505b to 578dc8b Compare May 27, 2025 06:01
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🔺 2 failing tests on test run #33 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
2 Failing620 Passing5 Skipped121m 5s

Details

Failing Tests
SpecTest
bucket-create-multicluster.spec.tsCloud Manager Cypress Tests→Object Storage Multicluster Bucket create » Object Storage Multicluster Bucket create
access-key.e2e.spec.tsCloud Manager Cypress Tests→object storage access key end-to-end tests » object storage access key end-to-end tests

Troubleshooting

Use this command to re-run the failing tests:

pnpm cy:run -s "cypress/e2e/core/objectStorageMulticluster/bucket-create-multicluster.spec.ts,cypress/e2e/core/objectStorage/access-key.e2e.spec.ts"

@hasyed-akamai
hasyed-akamai merged commit e9b18a2 into linode:develop May 30, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Design Tokens Laying the groundwork for Design Tokens Requires UX Approval Design System Component Requires UX Approval

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants