upcoming: [M3-9403] - Update copies for Linode Interfaces: Linode Details, Account Settings, Firewalls - #12131
Merged
Merged
Conversation
coliu-akamai
marked this pull request as ready for review
April 30, 2025 15:48
coliu-akamai
requested review from
bnussman-akamai,
hana-akamai and
hkhalil-akamai
and removed request for
a team
April 30, 2025 15:48
coliu-akamai
requested review from
jdamore-linode
and removed request for
a team
April 30, 2025 16:05
bnussman-akamai
left a comment
Member
There was a problem hiding this comment.
Looking very good so far. Just gonna do a bit more testing before approving
mjac0bs
approved these changes
Apr 30, 2025
mjac0bs
left a comment
Contributor
There was a problem hiding this comment.
Lots of little things going on in this PR, but I think things are working as intended from what I tested.
- Verified copy and didn't see any major issues, just noted a couple of places for potential improvement
- Confirmed the Add An IP Address button shows up in the IP table for Linodes with legacy interfaces, but not Linode interfaces
- Beta chip and interface IDs are present where described
- Dry run's new buttons and summary look good
Thanks Connie
bnussman-akamai
approved these changes
Apr 30, 2025
hkhalil-akamai
approved these changes
Apr 30, 2025
Contributor
Author
|
thanks everyone! addressed feedback + input the most recent copy updates including:
will merge this after all tests finish running |
Member
Contributor
Author
|
ty Banks! I'm gonna sneak that in once the e2e tests finish running 🙏 |
Cloud Manager UI test results🔺 1 failing test on test run #8 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/rebuild-linode.spec.ts" |
|||||||||||||||||
This was referenced May 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description 📝
Updates copy for various sections of the Linode Interface project
Changes 🔄
In addition to updating copies,
Upgrading interfaces:
Edit Interfaces
Account settings Network Interface type
Target release date 🗓️
5/6
Preview 📷
Include a screenshot or screen recording of the change.
🔒 Use the Mask Sensitive Data setting for security.
💡 Use
<video src="" />tag when including recordings in table.How to test 🧪
Verification steps
Note
Some copies (especially ones highlighed in blue in the spreadsheet) may be updated soon - they're being worked on
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅