Skip to content

fix: [M3-9941] - Radio Buttons should be small size in tables - #12261

Merged
bill-akamai merged 10 commits into
linode:developfrom
bill-akamai:M3-9941
May 29, 2025
Merged

fix: [M3-9941] - Radio Buttons should be small size in tables#12261
bill-akamai merged 10 commits into
linode:developfrom
bill-akamai:M3-9941

Conversation

@bill-akamai

@bill-akamai bill-akamai commented May 21, 2025

Copy link
Copy Markdown
Contributor

Description 📝

This PR sets the <Radio> size to the "small" size in the <PlanSection> table.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Set "small" size for radio buttons in <PlanSection> table.
  • Fix Storybook story so all radio button states can be easily previewed.

Preview 📷

Before After

Verification steps

  • Navigate to /linodes/create and confirm radio buttons are small size
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bill-akamai bill-akamai self-assigned this May 21, 2025
@bill-akamai bill-akamai added the Design Tokens Laying the groundwork for Design Tokens label May 21, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎗️ Reminder to self: get UX approval before merging

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping this!

@bill-akamai
bill-akamai marked this pull request as ready for review May 21, 2025 21:15
@bill-akamai
bill-akamai requested a review from a team as a code owner May 21, 2025 21:15
@bill-akamai
bill-akamai requested review from abailly-akamai and harsh-akamai and removed request for a team May 21, 2025 21:15

@abailly-akamai abailly-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thank you for adding Storybook coverage 🥇

@coliu-akamai coliu-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks @bill-akamai!

✅ plans panel in Linode Create
✅ plans panel in Linode Resize
✅ storybook

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping this!

@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager May 27, 2025
@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label May 27, 2025
@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 611 passing tests on test run #9 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing611 Passing4 Skipped114m 12s

@bill-akamai
bill-akamai merged commit 7977ece into linode:develop May 29, 2025
@github-project-automation github-project-automation Bot moved this from Approved to Merged in Cloud Manager May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Design Tokens Laying the groundwork for Design Tokens

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants