tech-story: [M3-9803] - Reroute Kubernetes - #12289
Conversation
There was a problem hiding this comment.
I was seeing some flakiness in this test, especially after this update (do not exactly know why but these changes seem to add resilience to the mock data)
| clusterId: Number(params.clusterId), | ||
| }), | ||
| path: 'clusters/$clusterID', | ||
| path: 'clusters/$clusterId', |
There was a problem hiding this comment.
The routing inheritance/nesting will be improved in subsequent PRs.
For now we care for routes to serve without regressions. CC @bnussman-akamai
see: #12294
mjac0bs
left a comment
There was a problem hiding this comment.
This looked good to me, it's just missing a changeset (or two, if you want one for correcting the lke-create.spec.ts flakiness).
- Create page, landing page, and details page routed correctly.
- Sorting, filtering, and pagination worked as expected.
- No regressions with cluster or NP actions.
coliu-akamai
left a comment
There was a problem hiding this comment.
thanks @abailly-akamai!
✅ kubernetes landing (sorting, pagination)
✅ create Kubernetes Cluster
✅ cluster detail
- ✅ Node pool sorting/paginating
- ✅ All actions
✅ Breadcrumbs
✅ code review
✅ lke linode linking
Cloud Manager UI test results🎉 625 passing tests on test run #15 ↗︎
|
Description 📝
Rerouting the
/kubernetesfeature as a whole.No handling of modals/dialogs routing. There is a follow up ticket to do so. The reasons are we are refining the approach of routing dialogs and we also want to get to the finish line quicker to get
react-router-domentirely replaced.Changes 🔄
Preview 📷
There should be no visual or functional regression as a result of this PR
How to test 🧪
Verification steps
Confirm no regression (UI/routing) with
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅