Skip to content

tech-story: [M3-9803] - Reroute Kubernetes - #12289

Merged
abailly-akamai merged 15 commits into
linode:developfrom
abailly-akamai:M3-9803
Jun 3, 2025
Merged

tech-story: [M3-9803] - Reroute Kubernetes#12289
abailly-akamai merged 15 commits into
linode:developfrom
abailly-akamai:M3-9803

Conversation

@abailly-akamai

@abailly-akamai abailly-akamai commented May 28, 2025

Copy link
Copy Markdown
Contributor

Description 📝

Rerouting the /kubernetes feature as a whole.

No handling of modals/dialogs routing. There is a follow up ticket to do so. The reasons are we are refining the approach of routing dialogs and we also want to get to the finish line quicker to get react-router-dom entirely replaced.

Changes 🔄

  • Replace routing utils
  • Adjust components code structure accordingly
  • Implement new sorting and pagination utils
  • Update unit tests
  • Update e2e

Preview 📷

There should be no visual or functional regression as a result of this PR

How to test 🧪

Verification steps

Confirm no regression (UI/routing) with

  • kubernetes landing (sorting, pagination)
  • create Kubernetes Cluster
  • cluster detail
    • Node pool sorting/paginating
    • All actions
  • Breadcrumbs
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was seeing some flakiness in this test, especially after this update (do not exactly know why but these changes seem to add resilience to the mock data)

@abailly-akamai
abailly-akamai marked this pull request as ready for review May 30, 2025 01:17
@abailly-akamai
abailly-akamai requested review from a team as code owners May 30, 2025 01:17
@abailly-akamai
abailly-akamai requested review from bnussman-akamai, coliu-akamai and dmcintyr-akamai and removed request for a team May 30, 2025 01:17
clusterId: Number(params.clusterId),
}),
path: 'clusters/$clusterID',
path: 'clusters/$clusterId',

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The routing inheritance/nesting will be improved in subsequent PRs.

For now we care for routes to serve without regressions. CC @bnussman-akamai

see: #12294

@mjac0bs
mjac0bs self-requested a review May 30, 2025 16:39

@mjac0bs mjac0bs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked good to me, it's just missing a changeset (or two, if you want one for correcting the lke-create.spec.ts flakiness).

  • Create page, landing page, and details page routed correctly.
  • Sorting, filtering, and pagination worked as expected.
  • No regressions with cluster or NP actions.

Comment thread packages/manager/src/features/Kubernetes/index.tsx
@github-project-automation github-project-automation Bot moved this from Review to Approved in Cloud Manager May 30, 2025
@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label May 30, 2025

@coliu-akamai coliu-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @abailly-akamai!

✅ kubernetes landing (sorting, pagination)
✅ create Kubernetes Cluster
✅ cluster detail

  • ✅ Node pool sorting/paginating
  • ✅ All actions

✅ Breadcrumbs
✅ code review
✅ lke linode linking

@linode-gh-bot

Copy link
Copy Markdown

Cloud Manager UI test results

🎉 625 passing tests on test run #15 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing625 Passing4 Skipped125m 49s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Missing Changeset Routing Refactor

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants